git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Eric Wong" <normalperson@yhbt.net>,
	"Karsten Blees" <karsten.blees@gmail.com>,
	"Stefan Beller" <stefanbeller@gmail.com>,
	"Torsten Bögershausen" <tboegi@web.de>,
	"Matthieu Moy" <Matthieu.Moy@imag.fr>,
	git@vger.kernel.org, "Michael Haggerty" <mhagger@alum.mit.edu>
Subject: [PATCH v2 0/2] Don't make $GIT_DIR executable
Date: Sun, 16 Nov 2014 08:21:46 +0100	[thread overview]
Message-ID: <1416122508-30654-1-git-send-email-mhagger@alum.mit.edu> (raw)

Changes since v1 [1]:

* Check the chmod() return result in create_default_files(), as
  suggested by Torsten Bögershausen.

* Fix a comment typo found by Stefan Beller.

* Extend patch 2/2 to also clearing the executable bits when "git
  config --edit" is run.

* Add test cases to patch 2/2 that the executable bits really are
  cleaned up when they should be.

Thanks to Stefan Beller, Torsten Bögershausen, and Eric Wong for their
feedback about v1.

I have also pushed this series to my GitHub fork [2].

Please remember that this patch series applies to maint. This version
has a couple of conflicts with master; I have pushed my proposed
conflict resolution to GitHub [3], including a preparatory commit that
I recommend for master.

[1] http://thread.gmane.org/gmane.comp.version-control.git/259620/focus=259620
[2] https://github.com/mhagger/git branch "config-non-executable"
[3] https://github.com/mhagger/git branch "config-non-executable-merge"

Michael Haggerty (2):
  create_default_files(): don't set u+x bit on $GIT_DIR/config
  config: clear the executable bits (if any) on $GIT_DIR/config

 builtin/config.c       | 21 ++++++++++++++++++---
 builtin/init-db.c      |  1 +
 config.c               | 12 ++++++++++--
 t/t1300-repo-config.sh | 13 +++++++++++++
 4 files changed, 42 insertions(+), 5 deletions(-)

-- 
2.1.1

             reply	other threads:[~2014-11-16  7:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-16  7:21 Michael Haggerty [this message]
2014-11-16  7:21 ` [PATCH v2 1/2] create_default_files(): don't set u+x bit on $GIT_DIR/config Michael Haggerty
2014-11-16 19:08   ` Junio C Hamano
2014-11-17  9:35     ` Michael Haggerty
2014-11-17  1:40   ` Eric Sunshine
2014-11-17  9:08     ` Torsten Bögershausen
2014-11-17 11:32       ` Michael Haggerty
2014-11-17  9:46     ` Michael Haggerty
2014-11-17 15:42       ` Junio C Hamano
2014-11-17 16:19         ` Michael Haggerty
2014-11-17 16:43           ` Junio C Hamano
2014-11-16  7:21 ` [PATCH v2 2/2] config: clear the executable bits (if any) " Michael Haggerty
2014-11-16  8:06   ` Johannes Sixt
2014-11-17  9:03     ` Michael Haggerty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416122508-30654-1-git-send-email-mhagger@alum.mit.edu \
    --to=mhagger@alum.mit.edu \
    --cc=Matthieu.Moy@imag.fr \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=karsten.blees@gmail.com \
    --cc=normalperson@yhbt.net \
    --cc=stefanbeller@gmail.com \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).