From: David Turner <dturner@twopensource.com>
To: Matthew Kaniaris <mkaniaris@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: ag, **, and the GPL
Date: Tue, 18 Nov 2014 12:57:36 -0500 [thread overview]
Message-ID: <1416333456.27401.1.camel@leckie> (raw)
In-Reply-To: <CACr0F2iGY_vxWzsNaPQNJ2cLUDRZPS70i79EhyA9OkA7qLaUQQ@mail.gmail.com>
On Mon, 2014-11-17 at 20:50 -0800, Matthew Kaniaris wrote:
> The Silver Search (https://github.com/ggreer/the_silver_searcher), is
> a small, open source, cross platform searching utility written as a
> replacement for ack. One of the major benefits of Ag (and a source
> for much of its speed) is that it obeys .gitignore. However, Ag
> currently treats gitignores as regexs which produces incorrect results
> for e.g. **. I'd like to add support to ag to obey the .gitignore
> spec but I'm not keen on implementing yet another fnmatch clone. Ag
> is licensed under the Apache License Version 2.0 which to the best of
> my understanding is incompatible with the GPLv2. Would you grant me
> permission to reuse wildmatch.c (and necessary includes) for use in
> Ag?
I already implemented this without using any git code at
https://github.com/novalis/the_silver_searcher. The patch was rejected
because it slowed down ag slightly (or perhaps because it was overly
complex).
next prev parent reply other threads:[~2014-11-18 17:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 4:50 ag, **, and the GPL Matthew Kaniaris
2014-11-18 6:20 ` Duy Nguyen
2014-11-18 17:57 ` David Turner [this message]
2014-11-19 0:48 ` Duy Nguyen
2014-11-19 1:51 ` David Turner
2014-11-18 19:09 ` Jonathan Nieder
2014-11-19 0:51 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416333456.27401.1.camel@leckie \
--to=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=mkaniaris@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).