From: Paul Smith <paul@mad-scientist.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v4] git-new-workdir: Don't fail if the target directory is empty
Date: Fri, 28 Nov 2014 13:34:05 -0500 [thread overview]
Message-ID: <1417199645.3562.6.camel@homebase> (raw)
In-Reply-To: <xmqqk32ho8mc.fsf@gitster.dls.corp.google.com>
On Wed, 2014-11-26 at 15:16 -0800, Junio C Hamano wrote:
> > $ ./src/git/contrib/workdir/git-new-workdir src/git foo master
> > mkdir: cannot create directory ‘foo’: Not a directory
> > unable to create new workdir "foo"!
>
> ;-) That comes from mkdir || fail which is indeed sufficient.
Right. Often I find it simpler/clearer to let the underlying commands
give the errors: they use perror() and can often provide more specific
error messages than my script can, unless I spend a lot of effort trying
to determine exactly what the problem is (permissions, disk space, bad
symlink, existing file, whatever).
Should I respin this with the \"$new_workdir\" -> '$new_workdir' change
(I actually prefer the latter myself but the former was used somewhere
so I kept it)?
next prev parent reply other threads:[~2014-11-28 18:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 20:38 [PATCH v4] git-new-workdir: Don't fail if the target directory is empty Paul Smith
2014-11-26 21:55 ` Junio C Hamano
2014-11-26 22:31 ` Paul Smith
2014-11-26 23:16 ` Junio C Hamano
2014-11-28 18:34 ` Paul Smith [this message]
2014-12-10 17:16 ` Paul Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417199645.3562.6.camel@homebase \
--to=paul@mad-scientist.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).