* [PATCH] t5400: remove dead code
@ 2014-12-16 3:58 Stefan Beller
2014-12-16 18:58 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Beller @ 2014-12-16 3:58 UTC (permalink / raw)
To: git, gitster; +Cc: Stefan Beller
Signed-off-by: Stefan Beller <sbeller@google.com>
---
Notes:
When debugging the atomic push series I wondered if we want to have
tests for the atomic push as well as for atomic send-pack.
So I looked at the t5400 test if I could easily add tests for send-pack.
I don't think I will add tests in here, but I found dead code.
Also I am rambling about the other series this patch is totally unrelated.
Removing dead code is always a joy!
Thanks,
Stefan
t/t5400-send-pack.sh | 16 +---------------
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/t/t5400-send-pack.sh b/t/t5400-send-pack.sh
index 0736bcb..04cea97 100755
--- a/t/t5400-send-pack.sh
+++ b/t/t5400-send-pack.sh
@@ -76,8 +76,7 @@ test_expect_success 'refuse pushing rewound head without --force' '
test "$victim_head" = "$pushed_head"
'
-test_expect_success \
- 'push can be used to delete a ref' '
+test_expect_success 'push can be used to delete a ref' '
( cd victim && git branch extra master ) &&
git send-pack ./victim :extra master &&
( cd victim &&
@@ -196,19 +195,6 @@ rewound_push_setup() {
)
}
-rewound_push_succeeded() {
- cmp ../parent/.git/refs/heads/master .git/refs/heads/master
-}
-
-rewound_push_failed() {
- if rewound_push_succeeded
- then
- false
- else
- true
- fi
-}
-
test_expect_success 'pushing explicit refspecs respects forcing' '
rewound_push_setup &&
parent_orig=$(cd parent && git rev-parse --verify master) &&
--
2.2.0.31.gad78000.dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] t5400: remove dead code
2014-12-16 3:58 [PATCH] t5400: remove dead code Stefan Beller
@ 2014-12-16 18:58 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2014-12-16 18:58 UTC (permalink / raw)
To: Stefan Beller; +Cc: git
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-16 18:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-16 3:58 [PATCH] t5400: remove dead code Stefan Beller
2014-12-16 18:58 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).