git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Beller <sbeller@google.com>
To: gitster@pobox.com, git@vger.kernel.org
Cc: Stefan Beller <sbeller@google.com>
Subject: [PATCH 1/2] Documentation/SubmittingPatches: Explain the rationale of git notes
Date: Wed, 17 Dec 2014 17:08:13 -0800	[thread overview]
Message-ID: <1418864895-18583-1-git-send-email-sbeller@google.com> (raw)
In-Reply-To: <xmqq1tnx961q.fsf@gitster.dls.corp.google.com>

This adds an explanation of why you want to have the --notes option
given to git format-patch.

Signed-off-by: Stefan Beller <sbeller@google.com>
---

Notes:
    > with optionally update Documentation/SubmittingPatches
    > to point at the file.
    
    That file actually talks about notes already.  I am sending
    two patches touching that file, one of them explaining
    the --notes workflow rationale and one of them just changing
    white spaces.
    
    A few weeks ago I wanted to patch format-patch to remove
    change ids. This is not needed any more for the git workflow
    as I disabled them and do not upload any patches to an optional
    Gerrit code review server anymore.
    
    I do like the workflow using --notes as well from a developers
    perspective as I take literally notes for my own sanity.
    I wonder if I should add a config format.notes = [default-off,
    always, on-if-non-empty] so I don't need always add --notes
    manually to the command line.
    
    Thanks,
    Stefan

 Documentation/SubmittingPatches | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index fa71b5f..16b5d65 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -176,7 +176,11 @@ message starts, you can put a "From: " line to name that person.
 You often want to add additional explanation about the patch,
 other than the commit message itself.  Place such "cover letter"
 material between the three dash lines and the diffstat. Git-notes
-can also be inserted using the `--notes` option.
+can also be inserted using the `--notes` option. If you are one
+of those developers who cannot write perfect code the first time
+and need multiple iterations of review and discussion, you are
+encouraged to use the notes to describe the changes between the
+different versions of a patch.
 
 Do not attach the patch as a MIME attachment, compressed or not.
 Do not let your e-mail client send quoted-printable.  Do not let
-- 
2.2.0.31.gad78000.dirty

       reply	other threads:[~2014-12-18  1:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <xmqq1tnx961q.fsf@gitster.dls.corp.google.com>
2014-12-18  1:08 ` Stefan Beller [this message]
2014-12-18  1:08   ` [PATCH] Documentation/SubmittingPatches: unify whitespace/tabs for the DCO Stefan Beller
2014-12-18  1:08   ` [PATCH 2/2] " Stefan Beller
2014-12-22 17:55     ` Junio C Hamano
2014-12-22 17:55   ` [PATCH 1/2] Documentation/SubmittingPatches: Explain the rationale of git notes Junio C Hamano
2014-12-29 17:36     ` Stefan Beller
2014-12-29 17:42     ` [PATCHv2] " Stefan Beller
2014-12-29 23:18       ` Eric Sunshine
2014-12-29 23:21         ` Stefan Beller
2014-12-30 16:19           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418864895-18583-1-git-send-email-sbeller@google.com \
    --to=sbeller@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).