git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: dev+git@drbeat.li
To: git@vger.kernel.org
Subject: [PATCH v2 2/5] update_unicode.sh: set UNICODE_DIR only once
Date: Fri, 19 Dec 2014 17:24:21 +0100	[thread overview]
Message-ID: <1419006264-24741-2-git-send-email-dev+git@drbeat.li> (raw)
In-Reply-To: <1419006264-24741-1-git-send-email-dev+git@drbeat.li>

From: Beat Bolli <dev+git@drbeat.li>

The value is the same on both uniset invocations, so "Don't Repeat
Yourself" applies.

Since we're in a subshell already, there's no need to unset UNICODE_DIR
at the end.

Signed-off-by: Beat Bolli <dev+git@drbeat.li>
---
 update_unicode.sh | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/update_unicode.sh b/update_unicode.sh
index c1c876c..bed8916 100755
--- a/update_unicode.sh
+++ b/update_unicode.sh
@@ -27,12 +27,13 @@ fi &&
 		fi &&
 		make
 	) && {
+		UNICODE_DIR=. && export UNICODE_DIR &&
 		echo "static const struct interval zero_width[] = {" &&
-		UNICODE_DIR=. ./uniset/uniset --32 cat:Me,Mn,Cf + U+1160..U+11FF - U+00AD |
+		./uniset/uniset --32 cat:Me,Mn,Cf + U+1160..U+11FF - U+00AD |
 		grep -v plane &&
 		echo "};" &&
 		echo "static const struct interval double_width[] = {" &&
-		UNICODE_DIR=. ./uniset/uniset --32 eaw:F,W &&
+		./uniset/uniset --32 eaw:F,W &&
 		echo "};"
 	} >$UNICODEWIDTH_H
 )
-- 
2.1.3

  reply	other threads:[~2014-12-19 16:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-19 16:24 [PATCH v2 1/5] update_unicode.sh: simplify output capture dev+git
2014-12-19 16:24 ` dev+git [this message]
2014-12-22 18:02   ` [PATCH v2 2/5] update_unicode.sh: set UNICODE_DIR only once Junio C Hamano
2014-12-23  0:32     ` Beat Bolli
2014-12-19 16:24 ` [PATCH v2 3/5] update_unicode.sh: shorten uniset invocation path dev+git
2014-12-19 16:24 ` [PATCH v2 4/5] update_unicode.sh: Make the output structure visible dev+git
2014-12-19 16:24 ` [PATCH v2 5/5] update_unicode.sh: Delete the command group dev+git
  -- strict thread matches above, loose matches on Subject: below --
2014-12-19 16:21 [PATCH v2 1/5] update_unicode.sh: simplify output capture dev+git
2014-12-19 16:21 ` [PATCH v2 2/5] update_unicode.sh: set UNICODE_DIR only once dev+git

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1419006264-24741-2-git-send-email-dev+git@drbeat.li \
    --to=dev+git@drbeat.li \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).