From: Philip Oakley <philipoakley@iee.org>
To: GitList <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Marius Storm-Olsen <mstormo@gmail.com>,
Ramsay Jones <ramsay@ramsay1.demon.co.uk>,
Jonathan Nieder <jrnieder@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Msysgit <msysgit@googlegroups.com>
Subject: [PATCH 5/5] engine.pl: provide more debug print statements
Date: Wed, 24 Dec 2014 10:47:14 +0000 [thread overview]
Message-ID: <1419418034-6276-6-git-send-email-philipoakley@iee.org> (raw)
In-Reply-To: <1419418034-6276-1-git-send-email-philipoakley@iee.org>
Assist developers transitioning between the two cultures
by including appropriate, but commented out, debug statements.
This acts as a poor man's --verbose option. The test suite doesn't
cover the contrib/buildsystems (or Msysgit's msvc-build) contributions
so fails to notice breakages there-in.
Signed-off-by: Philip Oakley <philipoakley@iee.org>
---
contrib/buildsystems/engine.pl | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/contrib/buildsystems/engine.pl b/contrib/buildsystems/engine.pl
index e913280..24a4c61 100755
--- a/contrib/buildsystems/engine.pl
+++ b/contrib/buildsystems/engine.pl
@@ -41,6 +41,7 @@ EOM
# Parse command-line options
while (@ARGV) {
my $arg = shift @ARGV;
+ #print "Arg: $arg \n";
if ("$arg" eq "-h" || "$arg" eq "--help" || "$arg" eq "-?") {
showUsage();
exit(0);
@@ -123,6 +124,7 @@ sub parseMakeOutput
print "Parsing GNU Make output to figure out build structure...\n";
my $line = 0;
while (my $text = shift @makedry) {
+ #print "Make: $text\n"; # show the makedry line
my $ate_next;
do {
$ate_next = 0;
@@ -257,6 +259,7 @@ sub handleCompileLine
} elsif ($part =~ /\.(c|cc|cpp)$/) {
$sourcefile = $part;
} else {
+ print "full line: $line\n";
die "Unhandled compiler option @ line $lineno: $part";
}
}
@@ -282,6 +285,7 @@ sub handleLibLine
$libout = $part;
$libout =~ s/\.a$//;
} else {
+ print "full line: $line\n";
die "Unhandled lib option @ line $lineno: $part";
}
}
--
2.1.0
next prev parent reply other threads:[~2014-12-24 10:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-24 10:47 [PATCH 0/5] Fix the Visual Studio 2008 .sln generator Philip Oakley
2014-12-24 10:47 ` [PATCH 1/5] engine.pl: Fix i18n -o option in msvc buildsystem generator Philip Oakley
2014-12-26 18:51 ` Philip Oakley
2014-12-24 10:47 ` [PATCH 2/5] engine.pl: Properly accept quoted spaces in filenames Philip Oakley
2014-12-24 10:47 ` [PATCH 3/5] engine.pl: ignore invalidcontinue.obj which is known to MSVC Philip Oakley
2014-12-24 10:47 ` [PATCH 4/5] vcbuild/readme: Improve layout and reference msvc-build script Philip Oakley
2014-12-24 10:47 ` Philip Oakley [this message]
2014-12-26 14:25 ` [PATCH 0/5] Fix the Visual Studio 2008 .sln generator Philip Oakley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419418034-6276-6-git-send-email-philipoakley@iee.org \
--to=philipoakley@iee.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=mstormo@gmail.com \
--cc=msysgit@googlegroups.com \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).