From: Richard Hansen <rhansen@bbn.com>
To: gitster@pobox.com
Cc: git@vger.kernel.org, rhansen@bbn.com
Subject: [PATCH v2 1/2] use 'test ...' instead of '[ ... ]'
Date: Tue, 6 Jan 2015 17:57:50 -0500 [thread overview]
Message-ID: <1420585071-28973-2-git-send-email-rhansen@bbn.com> (raw)
In-Reply-To: <1420585071-28973-1-git-send-email-rhansen@bbn.com>
(see Documentation/CodingGuidelines)
Signed-off-by: Richard Hansen <rhansen@bbn.com>
---
t/test-lib.sh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 9acdc88..3670eed 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -184,10 +184,10 @@ export _x05 _x40 _z40 LF u200c
# This test checks if command xyzzy does the right thing...
# '
# . ./test-lib.sh
-[ "x$ORIGINAL_TERM" != "xdumb" ] && (
+test "x$ORIGINAL_TERM" != "xdumb" && (
TERM=$ORIGINAL_TERM &&
export TERM &&
- [ -t 1 ] &&
+ test -t 1 &&
tput bold >/dev/null 2>&1 &&
tput setaf 1 >/dev/null 2>&1 &&
tput sgr0 >/dev/null 2>&1
@@ -684,7 +684,7 @@ test_done () {
then
error "Can't use skip_all after running some tests"
fi
- [ -z "$skip_all" ] || skip_all=" # SKIP $skip_all"
+ test -z "$skip_all" || skip_all=" # SKIP $skip_all"
if test $test_external_has_tap -eq 0
then
--
2.2.1
next prev parent reply other threads:[~2015-01-06 22:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 18:54 [PATCH] test-lib.sh: do tests for color support after changing HOME Richard Hansen
2015-01-06 19:06 ` Junio C Hamano
2015-01-06 22:57 ` [PATCH v2 0/2] " Richard Hansen
2015-01-06 22:57 ` Richard Hansen [this message]
2015-01-06 22:57 ` [PATCH v2 2/2] " Richard Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420585071-28973-2-git-send-email-rhansen@bbn.com \
--to=rhansen@bbn.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).