* [PATCH] git-svn: show progress in working_head_info()
@ 2015-01-10 13:21 Ramkumar Ramachandra
2015-01-10 22:21 ` Eric Wong
0 siblings, 1 reply; 3+ messages in thread
From: Ramkumar Ramachandra @ 2015-01-10 13:21 UTC (permalink / raw)
To: Git List; +Cc: Eric Wong
The working_head_info routine takes a very long time to execute on large
repositories. The least we can do is to comfort users that some progress
is being made.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
I was worried because of the long wait, so I wrote this to convince
myself that git-svn wasn't stuck.
git-svn.perl | 3 +++
1 file changed, 3 insertions(+)
diff --git a/git-svn.perl b/git-svn.perl
index 60f8814..6aa156c 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -2022,6 +2022,9 @@ sub working_head_info {
next;
}
next unless s{^\s*(git-svn-id:)}{$1};
+ my $chomped = $_;
+ chomp $chomped;
+ print "[Importing] $chomped\n";
my ($url, $rev, $uuid) = extract_metadata($_);
if (defined $url && defined $rev) {
next if $max{$url} and $max{$url} < $rev;
--
2.2.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] git-svn: show progress in working_head_info()
2015-01-10 13:21 [PATCH] git-svn: show progress in working_head_info() Ramkumar Ramachandra
@ 2015-01-10 22:21 ` Eric Wong
2015-01-14 22:40 ` Ramkumar Ramachandra
0 siblings, 1 reply; 3+ messages in thread
From: Eric Wong @ 2015-01-10 22:21 UTC (permalink / raw)
To: Ramkumar Ramachandra; +Cc: Git List
Ramkumar Ramachandra <artagnon@gmail.com> wrote:
> The working_head_info routine takes a very long time to execute on large
> repositories. The least we can do is to comfort users that some progress
> is being made.
>
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
> ---
> I was worried because of the long wait, so I wrote this to convince
> myself that git-svn wasn't stuck.
Unfortunately, this breaks show-ignore and t9101-git-svn-props.sh
show-ignore.expect show-ignore.got differ: char 1, line 1
not ok 23 - test show-ignore
Perhaps output should go to STDERR and also respect $_q?
> git-svn.perl | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/git-svn.perl b/git-svn.perl
> index 60f8814..6aa156c 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -2022,6 +2022,9 @@ sub working_head_info {
> next;
> }
> next unless s{^\s*(git-svn-id:)}{$1};
> + my $chomped = $_;
> + chomp $chomped;
> + print "[Importing] $chomped\n";
> my ($url, $rev, $uuid) = extract_metadata($_);
> if (defined $url && defined $rev) {
> next if $max{$url} and $max{$url} < $rev;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] git-svn: show progress in working_head_info()
2015-01-10 22:21 ` Eric Wong
@ 2015-01-14 22:40 ` Ramkumar Ramachandra
0 siblings, 0 replies; 3+ messages in thread
From: Ramkumar Ramachandra @ 2015-01-14 22:40 UTC (permalink / raw)
To: Eric Wong; +Cc: Git List
Eric,
I'm sorry, but this change isn't important enough for me to follow up.
Please merge the other two patches, if you think they're good.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-14 22:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-10 13:21 [PATCH] git-svn: show progress in working_head_info() Ramkumar Ramachandra
2015-01-10 22:21 ` Eric Wong
2015-01-14 22:40 ` Ramkumar Ramachandra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).