From: Alexander Kuleshov <kuleshovmail@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Alexander Kuleshov <kuleshovmail@gmail.com>
Subject: [PATCH] cat-file: remove unnecessary #include
Date: Sun, 11 Jan 2015 00:29:18 +0600 [thread overview]
Message-ID: <1420914558-5324-1-git-send-email-kuleshovmail@gmail.com> (raw)
"cache.h" is already included in "builtin.h"
It appeared at e83c51 (Initial revision of "git", the information manager
from hell., 8 Apr 2005) and used cache.c API (get_sha1_hex and read_sha1_file).
After this in the commit f81dae (Builtin git-cat-file., ) was included
"builtin.h", which already includes "cache.h", so we no need to include it in
the cat-file.c
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
builtin/cat-file.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/builtin/cat-file.c b/builtin/cat-file.c
index 750b5a2..2e6aaa1 100644
--- a/builtin/cat-file.c
+++ b/builtin/cat-file.c
@@ -3,7 +3,6 @@
*
* Copyright (C) Linus Torvalds, 2005
*/
-#include "cache.h"
#include "builtin.h"
#include "parse-options.h"
#include "userdiff.h"
--
2.2.1.532.g168b885.dirty
reply other threads:[~2015-01-10 18:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420914558-5324-1-git-send-email-kuleshovmail@gmail.com \
--to=kuleshovmail@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).