Git development
 help / color / mirror / Atom feed
From: Stefan Beller <sbeller@google.com>
To: gitster@pobox.com, git@vger.kernel.org, mhagger@alum.mit.edu
Cc: Stefan Beller <sbeller@google.com>
Subject: [PATCH] update-ref: Handle large transactions properly
Date: Tue, 20 Jan 2015 17:20:55 -0800	[thread overview]
Message-ID: <1421803255-4037-1-git-send-email-sbeller@google.com> (raw)

Test if we can do arbitrary large transactions. Currently this is a known
bug that we cannot do large transactions, so document it at least in the
test suite.

Signed-off-by: Stefan Beller <sbeller@google.com>
---
 t/t1400-update-ref.sh | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/t/t1400-update-ref.sh b/t/t1400-update-ref.sh
index 6805b9e..a7dd1ff 100755
--- a/t/t1400-update-ref.sh
+++ b/t/t1400-update-ref.sh
@@ -1065,4 +1065,31 @@ test_expect_success 'stdin -z delete refs works with packed and loose refs' '
 	test_must_fail git rev-parse --verify -q $c
 '
 
+run_with_limited_open_files () {
+	(ulimit -n 64 && "$@")
+}
+
+test_lazy_prereq ULIMIT 'run_with_limited_open_files true'
+
+test_expect_failure ULIMIT 'large transaction creating branches does not burst open file limit' '
+(
+	for i in $(seq 65)
+		echo "create refs/heads/$i HEAD"
+	done >large_input &&
+	git update-ref --stdin <large_input &&
+	git rev-parse --verify -q refs/heads/65
+)
+'
+
+test_expect_failure ULIMIT 'large transaction deleting branches does not burst open file limit' '
+(
+	for i in $(seq 33)
+	do
+		echo "delete refs/heads/$i HEAD"
+	done >large_input &&
+	git update-ref --stdin <large_input &&
+	test_must_fail git rev-parse --verify -q refs/heads/65
+)
+'
+
 test_done
-- 
2.2.1.62.g3f15098

             reply	other threads:[~2015-01-21  1:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-21  1:20 Stefan Beller [this message]
2015-01-21  1:21 ` [PATCH] update-ref: Handle large transactions properly Stefan Beller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421803255-4037-1-git-send-email-sbeller@google.com \
    --to=sbeller@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mhagger@alum.mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox