git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matt Korostoff <mkorostoff@gmail.com>
To: git@vger.kernel.org
Cc: Matt Korostoff <MKorostoff@gmail.com>
Subject: [PATCH] contrib/completion: suppress stderror in bash completion of git remotes
Date: Mon,  9 Feb 2015 15:58:28 -0500	[thread overview]
Message-ID: <1423515508-40109-1-git-send-email-MKorostoff@gmail.com> (raw)

In some system configurations there is a bug with the
__git_remotes function.  Specifically, there is a problem
with line 415, `test -d "$d/remotes" && ls -1 "$d/remotes"`.
While `test -d` is meant to prevent listing the remotes
directory if it does not exist, in some system, `ls` will
run regardless.

This results in an error in which typing `git push or` + `tab`
prints out `ls: .git/remotes: No such file or directory`.
This can be fixed by simply directing stderror of this line
to /dev/null.
---
 contrib/completion/git-completion.bash |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 2fece98..72251cc 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -412,7 +412,7 @@ __git_refs_remotes ()
 __git_remotes ()
 {
 	local i IFS=$'\n' d="$(__gitdir)"
-	test -d "$d/remotes" && ls -1 "$d/remotes"
+	test -d "$d/remotes" && ls -1 "$d/remotes" 2>/dev/null
 	for i in $(git --git-dir="$d" config --get-regexp 'remote\..*\.url' 2>/dev/null); do
 		i="${i#remote.}"
 		echo "${i/.url*/}"
-- 
1.7.10.2 (Apple Git-33)

             reply	other threads:[~2015-02-09 20:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-09 20:58 Matt Korostoff [this message]
2015-02-09 21:00 ` [PATCH] contrib/completion: suppress stderror in bash completion of git remotes Matt Korostoff
2015-02-09 21:09 ` Junio C Hamano
2015-02-10  0:08   ` Matt Korostoff
2015-02-10  2:10   ` [PATCH] contrib/completion: suppress stderror in bash SZEDER Gábor
2015-02-10 15:25     ` [PATCH] contrib/completion: deprecate __git_remotes in bash completion Matt Korostoff
2015-02-10 18:31     ` [PATCH] contrib/completion: suppress stderror in bash Junio C Hamano
2015-02-10 19:16       ` SZEDER Gábor
2015-03-04 14:04         ` SZEDER Gábor
2015-03-04 14:10           ` [PATCH 1/2] completion: add a test for __git_remotes() helper function SZEDER Gábor
2015-03-04 14:10             ` [PATCH 2/2] completion: simplify __git_remotes() SZEDER Gábor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423515508-40109-1-git-send-email-MKorostoff@gmail.com \
    --to=mkorostoff@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).