From: Mike Hommey <mh@glandium.org>
To: git@vger.kernel.org
Cc: gitster@pobox.com
Subject: [PATCH 1/3] transport-helper: emit progress and verbosity options after asking for capabilities
Date: Thu, 12 Feb 2015 19:09:59 +0900 [thread overview]
Message-ID: <1423735801-11108-1-git-send-email-mh@glandium.org> (raw)
Currently, the progress and verbosity options are only emitted for the fetch
and push commands, but they should also be emitted for other commands, such as
import or export, and, why not, even list.
Signed-off-by: Mike Hommey <mh@glandium.org>
---
transport-helper.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/transport-helper.c b/transport-helper.c
index 0224687..23a741c 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -98,6 +98,8 @@ static void do_take_over(struct transport *transport)
free(data);
}
+static void standard_options(struct transport *t);
+
static struct child_process *get_helper(struct transport *transport)
{
struct helper_data *data = transport->data;
@@ -212,6 +214,7 @@ static struct child_process *get_helper(struct transport *transport)
strbuf_release(&buf);
if (debug)
fprintf(stderr, "Debug: Capabilities complete.\n");
+ standard_options(transport);
return data->helper;
}
@@ -339,7 +342,6 @@ static int fetch_with_fetch(struct transport *transport,
int i;
struct strbuf buf = STRBUF_INIT;
- standard_options(transport);
if (data->check_connectivity &&
data->transport_options.check_self_contained_and_connected)
set_helper_option(transport, "check-connectivity", "true");
@@ -824,7 +826,6 @@ static int push_refs_with_push(struct transport *transport,
return 0;
}
- standard_options(transport);
for_each_string_list_item(cas_option, &cas_options)
set_helper_option(transport, "cas", cas_option->string);
--
2.3.0.1.g55ac403.dirty
next reply other threads:[~2015-02-12 10:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 10:09 Mike Hommey [this message]
2015-02-12 10:10 ` [PATCH 2/3] transport-helper: emit check-connectivity, cloning, and update-shallow options for import Mike Hommey
2015-02-12 10:10 ` [PATCH 3/3] transport-helper: fix typo in error message when --signed is not supported Mike Hommey
2015-02-12 10:20 ` Mike Hommey
2015-02-12 20:34 ` Junio C Hamano
2015-02-12 20:28 ` [PATCH 1/3] transport-helper: emit progress and verbosity options after asking for capabilities Junio C Hamano
2015-02-13 5:24 ` [PATCH 1/2] transport-helper: ask the helper to set progress and verbosity options after asking for its capabilities Mike Hommey
2015-02-13 5:24 ` [PATCH 2/2] transport-helper: ask the helper to set the same options for import as for fetch Mike Hommey
2015-02-13 19:36 ` Junio C Hamano
2015-02-13 22:14 ` Mike Hommey
2015-02-14 8:12 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423735801-11108-1-git-send-email-mh@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).