From: Alexander Kuleshov <kuleshovmail@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Alexander Kuleshov <kuleshovmail@gmail.com>
Subject: [PATCH 1/3] hash-object: add -v/--verbose option
Date: Mon, 2 Mar 2015 19:55:00 +0600 [thread overview]
Message-ID: <1425304500-14117-1-git-send-email-kuleshovmail@gmail.com> (raw)
This patch provides ability to pass -v/--verbose option to the
git hash-object command. hash-object will print not only hash,
but also file path of a file from what hash was calculated.
It can be useful in scripting, especially with --stdin-paths
option.
For example:
$ git hash-object -v test
e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 test
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
builtin/hash-object.c | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/builtin/hash-object.c b/builtin/hash-object.c
index 207b90c..97961ee 100644
--- a/builtin/hash-object.c
+++ b/builtin/hash-object.c
@@ -10,6 +10,8 @@
#include "parse-options.h"
#include "exec_cmd.h"
+static int verbose;
+
/*
* This is to create corrupt objects for debugging and as such it
* needs to bypass the data conversion performed by, and the type
@@ -43,7 +45,10 @@ static void hash_fd(int fd, const char *type, const char *path, unsigned flags,
die((flags & HASH_WRITE_OBJECT)
? "Unable to add %s to database"
: "Unable to hash %s", path);
- printf("%s\n", sha1_to_hex(sha1));
+ if (verbose)
+ printf("%s\t%s\n", sha1_to_hex(sha1), path);
+ else
+ printf("%s\n", sha1_to_hex(sha1));
maybe_flush_or_die(stdout, "hash to stdout");
}
@@ -79,7 +84,7 @@ static void hash_stdin_paths(const char *type, int no_filters, unsigned flags,
int cmd_hash_object(int argc, const char **argv, const char *prefix)
{
static const char * const hash_object_usage[] = {
- N_("git hash-object [-t <type>] [-w] [--path=<file> | --no-filters] [--stdin] [--] <file>..."),
+ N_("git hash-object [-t <type>] [-w] [-v] [--path=<file> | --no-filters] [--stdin] [--] <file>..."),
N_("git hash-object --stdin-paths < <list-of-paths>"),
NULL
};
@@ -99,6 +104,7 @@ int cmd_hash_object(int argc, const char **argv, const char *prefix)
OPT_BOOL( 0 , "no-filters", &no_filters, N_("store file as is without filters")),
OPT_BOOL( 0, "literally", &literally, N_("just hash any random garbage to create corrupt objects for debugging Git")),
OPT_STRING( 0 , "path", &vpath, N_("file"), N_("process file as it were from this path")),
+ OPT__VERBOSE(&verbose, N_("show hash and file path")),
OPT_END()
};
int i;
@@ -108,6 +114,11 @@ int cmd_hash_object(int argc, const char **argv, const char *prefix)
argc = parse_options(argc, argv, NULL, hash_object_options,
hash_object_usage, 0);
+ if (verbose & literally)
+ errstr = "Can't use --verbose with --literally";
+ else if (verbose & hashstdin)
+ errstr = "Can't use --verbose with --stdin";
+
if (flags & HASH_WRITE_OBJECT) {
prefix = setup_git_directory();
prefix_length = prefix ? strlen(prefix) : 0;
--
2.3.1.167.g7f4ba4b.dirty
next reply other threads:[~2015-03-02 13:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 13:55 Alexander Kuleshov [this message]
2015-03-02 13:55 ` [PATCH 2/3] t1007-hash-object: add tests for verbose hash-object Alexander Kuleshov
2015-03-02 13:55 ` [PATCH 3/3] Documentation/git-hash-object.txt: add verbose option for hash-object Alexander Kuleshov
2015-03-02 15:12 ` [PATCH 1/3] hash-object: add -v/--verbose option Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425304500-14117-1-git-send-email-kuleshovmail@gmail.com \
--to=kuleshovmail@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).