git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Akshay Aurora <akshayaurora@yahoo.com>
To: git@vger.kernel.org
Cc: Akshay Aurora <akshayaurora@yahoo.com>
Subject: [PATCH][GSoC] revision: forbid --graph and --no-walk usage
Date: Fri,  6 Mar 2015 00:13:30 -0500	[thread overview]
Message-ID: <1425618810-21192-1-git-send-email-akshayaurora@yahoo.com> (raw)

Signed-off-by: Akshay Aurora <akshayaurora@yahoo.com>
---
This is my first patch for a GSoC Microproject, would be great to have your feedback.

 revision.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/revision.c b/revision.c
index bd027bc..d578652 100644
--- a/revision.c
+++ b/revision.c
@@ -2248,7 +2248,8 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s
 	 */
 	if (revs->reverse && revs->graph)
 		die("cannot combine --reverse with --graph");
-
+	if (revs->no_walk && revs->graph)
+		die("cannot combine --no-walk with --graph");
 	if (revs->reflog_info && revs->graph)
 		die("cannot combine --walk-reflogs with --graph");
 	if (!revs->reflog_info && revs->grep_filter.use_reflog_filter)
-- 
2.3.1

             reply	other threads:[~2015-03-06  5:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-06  5:13 Akshay Aurora [this message]
2015-03-06 18:30 ` [PATCH][GSoC] revision: forbid --graph and --no-walk usage Junio C Hamano
2015-03-06 20:57   ` Akshay Aurora
2015-03-08 10:13     ` Matthieu Moy
     [not found] <1425582632-28273-1-git-send-email-akshayaurora@yahoo.com>
2015-03-06  5:08 ` Akshay Aurora
2015-03-06  8:37   ` Max Kirillov
2015-03-06 12:11     ` Akshay Aurora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425618810-21192-1-git-send-email-akshayaurora@yahoo.com \
    --to=akshayaurora@yahoo.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).