GSoC applicants: discuss other applicants patches, perhaps?

GSoC applicants: discuss other applicants patches, perhaps?

[Junio C Hamano]

The objective of GSoC program is to learn how to work on
projects as a part of an open source community, and working
in Git project is not only about writing your own patches.
Constructively critiquing design and implementation of
patches by other people is also an important skill you need
to learn in order to effectively collaborate with others.

So, if you have time and inclination, it would be beneficial
to read and understand other applicants' patches, think if
you agree that the problem they are trying to solve is worth
solving, the approach they are taking is the best way (or
if you think of a better way to solve it), etc., and respond
to their patches with the result of your thinking as a review.

What do mentors and others think?

[PATCH] Suggest applicants to participate in review of other peoples' patches

[Matthieu Moy]

Idea and most of the wording comes from Junio's message on the list. I
added a hint to include links to review in the application (which makes
the suggestion a bit stronger since it implies that it will be taken into
account in the selection).

Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
> What do mentors and others think?

Very good idea indeed.

 SoC-2015-Ideas.md | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/SoC-2015-Ideas.md b/SoC-2015-Ideas.md
index 0ccbcdc..ba8b25e 100644
--- a/SoC-2015-Ideas.md
+++ b/SoC-2015-Ideas.md
@@ -16,9 +16,22 @@ way for us to get experience with applicants, but it will also help
 applicants become familiar with Git's development and submission
 process.
 
+Also, working in Git project is not only about writing your own
+patches. Constructively critiquing design and implementation of
+patches by other people is also an important skill you need to learn
+in order to effectively collaborate with others. So, if you have time
+and inclination, it would be beneficial to read and understand other
+applicants' patches (or any other patch submitted to the mailing-list),
+think if you agree that the problem they are trying to solve is worth
+solving, the approach they are taking is the best way (or if you think
+of a better way to solve it), etc., and respond to their patches with
+the result of your thinking as a review.
+
 Please, include link(s) to the mailing-list discussion(s) related to
 your microproject in your application (e.g. linking to
-[gmane](http://news.gmane.org/gmane.comp.version-control.git)).
+[gmane](http://news.gmane.org/gmane.comp.version-control.git)). If you
+participate in the review of other patches, then you may also include
+links to discussions that would support your application.
 
 ## Note about the number of slots
 
-- 
2.3.0.157.g79e124b

Re: [PATCH] Suggest applicants to participate in review of other peoples' patches

[Jeff King]

On Fri, Mar 06, 2015 at 12:53:57PM +0100, Matthieu Moy wrote:

> Idea and most of the wording comes from Junio's message on the list. I
> added a hint to include links to review in the application (which makes
> the suggestion a bit stronger since it implies that it will be taken into
> account in the selection).

Seems reasonable. I do not know what the quality of reviews will be from
applicants, but I guess we will find out. :)

-Peff

Re: [PATCH] Suggest applicants to participate in review of other peoples' patches

[Junio C Hamano]

Jeff King <peff@peff.net> writes:

> On Fri, Mar 06, 2015 at 12:53:57PM +0100, Matthieu Moy wrote:
>
>> Idea and most of the wording comes from Junio's message on the list. I
>> added a hint to include links to review in the application (which makes
>> the suggestion a bit stronger since it implies that it will be taken into
>> account in the selection).
>
> Seems reasonable. I do not know what the quality of reviews will be from
> applicants, but I guess we will find out. :)

I actually was hoping to see an applicant replaying the review
comments given to him to another applicant that makes the same kind
of mistakes.  That is a fairly easy entry to get into reviewing
process---even you may not yet know what you are suggesting the
other to do is the norm in this community, if a more experienced
person told you something similar, it would be likely it is.

Re: [PATCH] Suggest applicants to participate in review of other peoples' patches

[Matthieu Moy]

Junio C Hamano <gitster@pobox.com> writes:

> Jeff King <peff@peff.net> writes:
>
>> On Fri, Mar 06, 2015 at 12:53:57PM +0100, Matthieu Moy wrote:
>>
>>> Idea and most of the wording comes from Junio's message on the list. I
>>> added a hint to include links to review in the application (which makes
>>> the suggestion a bit stronger since it implies that it will be taken into
>>> account in the selection).
>>
>> Seems reasonable. I do not know what the quality of reviews will be from
>> applicants, but I guess we will find out. :)
>
> I actually was hoping to see an applicant replaying the review
> comments given to him to another applicant that makes the same kind
> of mistakes.

I'm also hoping that applicants just watch the mailing-list better, and
even if the don't actually write much, that they read a bit more what's
going on here.

I pushed my patch.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/