git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Beller <sbeller@google.com>
To: gitster@pobox.com
Cc: git@vger.kernel.org, Stefan Beller <sbeller@google.com>
Subject: [PATCH 2/3] bundle.c: fix memory leak
Date: Mon,  9 Mar 2015 09:58:23 -0700	[thread overview]
Message-ID: <1425920304-22360-2-git-send-email-sbeller@google.com> (raw)
In-Reply-To: <1425920304-22360-1-git-send-email-sbeller@google.com>

The continue statements nearby also have an accompanying free(ref);

Signed-off-by: Stefan Beller <sbeller@google.com>
---
 bundle.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/bundle.c b/bundle.c
index 2e2dbd5..534783d 100644
--- a/bundle.c
+++ b/bundle.c
@@ -342,6 +342,7 @@ static int write_bundle_refs(int bundle_fd, struct rev_info *revs)
 		if (e->item->type == OBJ_TAG &&
 				!is_tag_in_date_range(e->item, revs)) {
 			e->item->flags |= UNINTERESTING;
+			free(ref);
 			continue;
 		}
 
-- 
2.3.0.81.gc37f363

  reply	other threads:[~2015-03-09 16:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-09 16:58 [PATCH 1/3] connect.c: Fix memory leak Stefan Beller
2015-03-09 16:58 ` Stefan Beller [this message]
2015-03-10 22:40   ` [PATCH 2/3] bundle.c: fix " Junio C Hamano
2015-03-10 23:08     ` Stefan Beller
2015-03-10 23:17       ` Junio C Hamano
2015-03-10 23:51         ` Stefan Beller
2015-03-11  3:57           ` Junio C Hamano
2015-03-09 16:58 ` [PATCH 3/3] builtin/help.c: " Stefan Beller
2015-03-10 22:43   ` Junio C Hamano
2015-03-10 23:50     ` Stefan Beller
2015-03-11  3:52       ` Junio C Hamano
2015-03-09 19:23 ` [PATCH 1/3] connect.c: Fix " Torsten Bögershausen
2015-03-10 22:35 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425920304-22360-2-git-send-email-sbeller@google.com \
    --to=sbeller@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).