From: Alexander Kuleshov <kuleshovmail@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
Alexander Kuleshov <kuleshovmail@gmail.com>
Subject: [PATCH] git.c: two memory leak fixes
Date: Sun, 15 Mar 2015 00:43:33 +0600 [thread overview]
Message-ID: <1426358613-30180-1-git-send-email-kuleshovmail@gmail.com> (raw)
This patch provides fixes for two minor memory leaks in the
handle_alias function:
1. We allocate memory for alias_argv with the xmalloc function call,
after run_command_v_opt function will be executed we no need in this
variable anymore, so let's free it.
2. Memory allocated for alias_string variable in the alias_lookup function,
need to free it.
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
git.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/git.c b/git.c
index 086fac1..501e5bd 100644
--- a/git.c
+++ b/git.c
@@ -252,6 +252,7 @@ static int handle_alias(int *argcp, const char ***argv)
alias_argv[argc] = NULL;
ret = run_command_v_opt(alias_argv, RUN_USING_SHELL);
+ free(alias_argv);
if (ret >= 0) /* normal exit */
exit(ret);
@@ -259,6 +260,7 @@ static int handle_alias(int *argcp, const char ***argv)
alias_command, alias_string + 1);
}
count = split_cmdline(alias_string, &new_argv);
+ free(alias_string);
if (count < 0)
die("Bad alias.%s string: %s", alias_command,
split_cmdline_strerror(count));
--
2.3.3.469.g69a3822.dirty
next reply other threads:[~2015-03-14 18:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-14 18:43 Alexander Kuleshov [this message]
2015-03-15 2:18 ` [PATCH] git.c: two memory leak fixes Junio C Hamano
2015-03-15 11:53 ` Alexander Kuleshov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426358613-30180-1-git-send-email-kuleshovmail@gmail.com \
--to=kuleshovmail@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).