git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Beller <sbeller@google.com>
To: gitster@pobox.com
Cc: git@vger.kernel.org, Stefan Beller <sbeller@google.com>
Subject: [PATCH 08/15] http-push: Remove unneeded cleanup
Date: Fri, 20 Mar 2015 17:28:05 -0700	[thread overview]
Message-ID: <1426897692-18322-9-git-send-email-sbeller@google.com> (raw)
In-Reply-To: <1426897692-18322-1-git-send-email-sbeller@google.com>

preq is NULL as the condition the line before dictates. And the cleanup
function release_http_pack_request is not null pointer safe.

Signed-off-by: Stefan Beller <sbeller@google.com>
---
 http-push.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/http-push.c b/http-push.c
index bfb1c96..c98dad2 100644
--- a/http-push.c
+++ b/http-push.c
@@ -316,7 +316,6 @@ static void start_fetch_packed(struct transfer_request *request)
 
 	preq = new_http_pack_request(target, repo->url);
 	if (preq == NULL) {
-		release_http_pack_request(preq);
 		repo->can_update_info_refs = 0;
 		return;
 	}
-- 
2.3.0.81.gc37f363

  parent reply	other threads:[~2015-03-21  0:28 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-21  0:27 [PATCH 00/15] Fixing memory leaks Stefan Beller
2015-03-21  0:27 ` [PATCH 01/15] read-cache: fix memleak Stefan Beller
2015-03-21  3:26   ` Junio C Hamano
2015-03-23 16:24     ` Stefan Beller
2015-03-23 17:57       ` [PATCH 1/2] " Stefan Beller
2015-03-23 17:57         ` [PATCH 2/2] read-cache.c: fix a memleak in add_to_index Stefan Beller
2015-03-23 18:07           ` Junio C Hamano
2015-03-23 18:11         ` [PATCH 1/2] read-cache: fix memleak Junio C Hamano
2015-03-21  0:27 ` [PATCH 02/15] read-cache: Improve readability Stefan Beller
2015-03-21  4:19   ` Junio C Hamano
2015-03-21  5:11     ` Stefan Beller
2015-03-22 19:26       ` Junio C Hamano
2015-03-21  0:28 ` [PATCH 03/15] read-cache: free cache entry in add_to_index in case of early return Stefan Beller
2015-03-21  3:31   ` Junio C Hamano
2015-03-21  5:10     ` Stefan Beller
2015-03-22 19:11       ` Junio C Hamano
2015-03-21  0:28 ` [PATCH 04/15] update-index: fix a memleak Stefan Beller
2015-03-21  3:40   ` Junio C Hamano
2015-03-23 16:53     ` [PATCH] update-index: Don't copy memory around Stefan Beller
2015-03-23 17:11       ` Junio C Hamano
2015-03-21  0:28 ` [PATCH 05/15] builtin/apply.c: fix a memleak Stefan Beller
2015-03-21  3:45   ` Junio C Hamano
2015-03-23 17:13     ` [PATCH] builtin/apply.c: fix a memleak (Fixup, squashable) Stefan Beller
2015-03-23 17:27       ` Junio C Hamano
2015-03-21  0:28 ` [PATCH 06/15] merge-blobs.c: Fix a memleak Stefan Beller
2015-03-21  0:28 ` [PATCH 07/15] merge-recursive: fix memleaks Stefan Beller
2015-03-21  3:48   ` Junio C Hamano
2015-03-21  0:28 ` Stefan Beller [this message]
2015-03-21  0:28 ` [PATCH 09/15] http: release the memory of a http pack request as well Stefan Beller
2015-03-22 19:36   ` Junio C Hamano
2015-03-24 16:54     ` Stefan Beller
2015-03-24 17:48       ` Junio C Hamano
2015-03-21  0:28 ` [PATCH 10/15] commit.c: fix a memory leak Stefan Beller
2015-03-21  3:59   ` Junio C Hamano
2015-03-24 13:42     ` Duy Nguyen
2015-03-24 21:17       ` Re* " Junio C Hamano
2015-03-24 21:20         ` Stefan Beller
2015-03-21  0:28 ` [PATCH 11/15] builtin/check-attr: fix a memleak Stefan Beller
2015-03-21  4:02   ` Junio C Hamano
2015-03-21  0:28 ` [PATCH 12/15] builtin/merge-base: fix memleak Stefan Beller
2015-03-21  0:28 ` [PATCH 13/15] builtin/unpack-file: fix a memleak Stefan Beller
2015-03-21  0:28 ` [PATCH 14/15] builtin/cat-file: free memleak Stefan Beller
2015-03-21  0:28 ` [PATCH 15/15] ls-files: fix a memleak Stefan Beller
2015-03-21  3:21 ` [PATCH 00/15] Fixing memory leaks Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426897692-18322-9-git-send-email-sbeller@google.com \
    --to=sbeller@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).