From: Paul Tan <pyokagan@gmail.com>
To: git@vger.kernel.org
Cc: Paul Tan <pyokagan@gmail.com>
Subject: [PATCH] enter_repo(): fix suffix precedence documentation
Date: Mon, 30 Mar 2015 18:30:33 +0800 [thread overview]
Message-ID: <1427711433-3104-1-git-send-email-pyokagan@gmail.com> (raw)
The ordering of the list of suffixes tested in enter_repo() is
documented as "%s.git/.git", "%s/.git", "%s.git", "%s". This does not
match the ordering of the list of suffixes tested in the code which is
"%s/.git", "%s", "%s.git/.git", "%s.git". Fix this.
Signed-off-by: Paul Tan <pyokagan@gmail.com>
---
path.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/path.c b/path.c
index e608993..6479352 100644
--- a/path.c
+++ b/path.c
@@ -303,8 +303,8 @@ return_null:
* (3) "relative/path" to mean cwd relative directory; or
* (4) "/absolute/path" to mean absolute directory.
*
- * Unless "strict" is given, we try access() for existence of "%s.git/.git",
- * "%s/.git", "%s.git", "%s" in this order. The first one that exists is
+ * Unless "strict" is given, we try access() for existence of "%s/.git",
+ * "%s", "%s.git/.git", "%s.git" in this order. The first one that exists is
* what we try.
*
* Second, we try chdir() to that. Upon failure, we return NULL.
--
2.1.4
next reply other threads:[~2015-03-30 10:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 10:30 Paul Tan [this message]
2015-03-30 11:08 ` [PATCH] enter_repo(): fix suffix precedence documentation Matthieu Moy
2015-03-31 13:39 ` [PATCH v2] enter_repo(): fix docs to match code Paul Tan
2015-03-31 17:35 ` Junio C Hamano
2015-03-31 17:41 ` Jeff King
2015-03-31 17:57 ` Junio C Hamano
2015-03-31 18:10 ` [PATCH v3] " Paul Tan
2015-03-30 11:44 ` [PATCH] enter_repo(): fix suffix precedence documentation Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427711433-3104-1-git-send-email-pyokagan@gmail.com \
--to=pyokagan@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).