From: Luke Diamand <luke@diamand.org>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
Luke Diamand <luke@diamand.org>
Subject: [PATCH] Fixup test-lint error in git-p4 t9814 test
Date: Mon, 27 Apr 2015 23:20:27 +0100 [thread overview]
Message-ID: <1430173228-22004-1-git-send-email-luke@diamand.org> (raw)
While running the git-p4 tests, I noticed that t9814 has started
failing due to the (very ingenious!) chain-lint detection introduced
in:
bb79af9 t/test-lib: introduce --chain-lint option
I think that what's going on is that the chain-lint test is
getting itself confused by this test, which is designed to always
succeed, regardless of whether the individual sub-commands succeed
or not, since it's just setting up a pre-requisite for later use.
I've added an additional set of braces, which makes it clearer
to the --chain-lint code what's going on, but I'd be interested to
know if this is the right way to fix this.
Thanks,
Luke
Luke Diamand (1):
git-p4: prevent --chain-lint failure
t/t9814-git-p4-rename.sh | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
--
2.3.4.48.g223ab37
next reply other threads:[~2015-04-27 22:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 22:20 Luke Diamand [this message]
2015-04-27 22:20 ` [PATCH] git-p4: prevent --chain-lint failure Luke Diamand
2015-04-27 23:02 ` Jeff King
2015-04-28 6:30 ` [PATCHv2] Fixup test-lint error in git-p4 t9814 test Luke Diamand
2015-04-28 7:21 ` [PATCHv3] " Luke Diamand
2015-04-28 7:21 ` [PATCHv3] git-p4: t9814: prevent --chain-lint failure Luke Diamand
2015-04-28 6:30 ` [PATCHv2] " Luke Diamand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430173228-22004-1-git-send-email-luke@diamand.org \
--to=luke@diamand.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).