git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luke Diamand <luke@diamand.org>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Luke Diamand <luke@diamand.org>
Subject: [PATCH] git-p4: Fix ocasional test failures in kill_p4d
Date: Wed, 29 Apr 2015 22:26:08 +0100	[thread overview]
Message-ID: <1430342769-20521-1-git-send-email-luke@diamand.org> (raw)

Running the git-p4 unit tests, I notice that the 'kill_p4d' test
occasionally fails. This just terminates the p4d server, so in
theory it should always succeed. The problem is especially
noticeable when running multiple tests in parallel:

    $ make -C t T=t98*.sh -j50

That's annoying, as it makes it harder to test changes to git-p4.

It looks like p4d is sensitive to being killed ungracefully.
Experimentally, I find that starting it with journalling disabled,
and using 'p4 admin stop' rather than kill(1) makes the process much
more reliable; I no longer see the intermittent failures.


Luke Diamand (1):
  git-p4: fix occasional test failure in kill_p4d

 t/lib-git-p4.sh | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

-- 
2.3.4.48.g223ab37

             reply	other threads:[~2015-04-29 21:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-29 21:26 Luke Diamand [this message]
2015-04-29 21:26 ` [PATCH] git-p4: fix occasional test failure in kill_p4d Luke Diamand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430342769-20521-1-git-send-email-luke@diamand.org \
    --to=luke@diamand.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).