From: David Turner <dturner@twopensource.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, David Turner <dturner@twitter.com>
Subject: Re: [PATCH v2 2/3] sha1_name: get_sha1_with_context learns to follow symlinks
Date: Sat, 09 May 2015 16:02:46 -0400 [thread overview]
Message-ID: <1431201766.24139.1.camel@ubuntu> (raw)
In-Reply-To: <xmqq7fsiifcz.fsf@gitster.dls.corp.google.com>
On Fri, 2015-05-08 at 20:45 -0700, Junio C Hamano wrote:
> dturner@twopensource.com writes:
>
> > From: David Turner <dturner@twitter.com>
> >
> > Wire up get_sha1_with_context to call get_tree_entry_follow_symlinks
> > when GET_SHA1_FOLLOW_SYMLINKS is passed in flags. G_S_FOLLOW_SYMLINKS
> > is incompatible with G_S_ONLY_TO_DIE because the diagnosis that
> > ONLY_TO_DIE triggers does not consider symlinks.
>
> Is "does not consider" something fundamental, or it just happens to
> be that way right now?
It just happens to be that way right now. It would require work
approximately equivalent to this patch series to fix.
next prev parent reply other threads:[~2015-05-09 20:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 22:38 [PATCH v2 1/3] tree-walk: learn get_tree_entry_follow_symlinks dturner
2015-05-08 22:38 ` [PATCH v2 2/3] sha1_name: get_sha1_with_context learns to follow symlinks dturner
2015-05-09 3:45 ` Junio C Hamano
2015-05-09 17:39 ` Junio C Hamano
2015-05-09 20:34 ` David Turner
2015-05-09 20:02 ` David Turner [this message]
2015-05-08 22:38 ` [PATCH v2 3/3] cat-file: add --follow-symlinks to --batch dturner
2015-05-09 5:00 ` [PATCH v2 1/3] tree-walk: learn get_tree_entry_follow_symlinks Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431201766.24139.1.camel@ubuntu \
--to=dturner@twopensource.com \
--cc=dturner@twitter.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).