From: David Turner <dturner@twopensource.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, David Turner <dturner@twitter.com>
Subject: Re: [PATCH] builtin/clean.c: Handle disappearing files
Date: Fri, 15 May 2015 14:13:32 -0400 [thread overview]
Message-ID: <1431713612.17436.27.camel@ubuntu> (raw)
In-Reply-To: <xmqqy4kqh0n8.fsf@gitster.dls.corp.google.com>
On Thu, 2015-05-14 at 22:26 -0700, Junio C Hamano wrote:
<snip>
OK, I'm sold that this patch is not a great idea. But:
> If your "build statistics" thing
> created a temporary before "clean" started to run (causing 'clean'
> to notice that as a cruft), and if "clean" gets to remove it before
> the "build statistics" thing finishes what it was doing accumulating
> whatever data in that file, when "build statistics" thing finally
> tries to use the file, it no longer is there.
Only if the build statistics file is included in the pathspec for
clean.
So maybe we should just move the lstat below the pathspec check. This
is probably faster in some cases anyway. What do you think?
next prev parent reply other threads:[~2015-05-15 18:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 21:16 [PATCH] builtin/clean.c: Handle disappearing files David Turner
2015-05-14 21:45 ` Junio C Hamano
2015-05-14 21:52 ` David Turner
2015-05-14 22:14 ` Junio C Hamano
2015-05-14 22:33 ` David Turner
2015-05-15 5:26 ` Junio C Hamano
2015-05-15 18:13 ` David Turner [this message]
2015-05-16 19:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431713612.17436.27.camel@ubuntu \
--to=dturner@twopensource.com \
--cc=dturner@twitter.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).