From: David Aguilar <davvid@gmail.com>
To: Phil Susi <phillsusi@gmail.com>, git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Philip Oakley" <philipoakley@iee.org>,
"Johannes Schindelin" <johannes.schindelin@gmx.de>,
"Sebastian Schuberth" <sschuberth@gmail.com>,
"SZEDER Gábor" <szeder@ira.uka.de>
Subject: [PATCH v5 1/2] mergetool--lib: set IFS for difftool and mergetool
Date: Wed, 20 May 2015 02:02:41 -0700 [thread overview]
Message-ID: <1432112562-400-1-git-send-email-davvid@gmail.com> (raw)
git-sh-setup sets IFS but it is not used by git-difftool--helper.
Set IFS in git-mergetool--lib so that the mergetool scriptlets,
diftool, and mergetool do not need to do so.
Signed-off-by: David Aguilar <davvid@gmail.com>
---
This patch is new since last time. It simplifies the patch that follows.
git-mergetool--lib.sh | 3 +++
git-mergetool.sh | 2 --
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/git-mergetool--lib.sh b/git-mergetool--lib.sh
index fe61e89..14b039d 100644
--- a/git-mergetool--lib.sh
+++ b/git-mergetool--lib.sh
@@ -2,6 +2,9 @@
: ${MERGE_TOOLS_DIR=$(git --exec-path)/mergetools}
+IFS='
+'
+
mode_ok () {
if diff_mode
then
diff --git a/git-mergetool.sh b/git-mergetool.sh
index d20581c..9f77e3a 100755
--- a/git-mergetool.sh
+++ b/git-mergetool.sh
@@ -451,8 +451,6 @@ fi
printf "Merging:\n"
printf "%s\n" "$files"
-IFS='
-'
rc=0
for i in $files
do
--
2.4.1.218.gc09a0e5
next reply other threads:[~2015-05-20 9:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 9:02 David Aguilar [this message]
2015-05-20 9:02 ` [PATCH v5 2/2] mergetools: add winmerge as a builtin tool David Aguilar
2015-05-20 9:04 ` [PATCH v5 1/2] mergetool--lib: set IFS for difftool and mergetool Sebastian Schuberth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432112562-400-1-git-send-email-davvid@gmail.com \
--to=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=philipoakley@iee.org \
--cc=phillsusi@gmail.com \
--cc=sschuberth@gmail.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).