From: Paul Tan <pyokagan@gmail.com>
To: git@vger.kernel.org
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>,
Stefan Beller <sbeller@google.com>, Paul Tan <pyokagan@gmail.com>,
Jeff King <peff@peff.net>
Subject: [PATCH v5 6/8] t5520: test --rebase failure on unborn branch with index
Date: Fri, 29 May 2015 19:44:43 +0800 [thread overview]
Message-ID: <1432899885-25143-7-git-send-email-pyokagan@gmail.com> (raw)
In-Reply-To: <1432899885-25143-1-git-send-email-pyokagan@gmail.com>
Commit 19a7fcb (allow pull --rebase on branch yet to be born,
2009-08-11) special cases git-pull on an unborn branch in a different
code path such that git-pull --rebase is still valid even though there
is no HEAD yet.
This code path still ensures that there is no index in order not to lose
any staged changes. Implement a test to ensure that this check is
triggered.
Signed-off-by: Paul Tan <pyokagan@gmail.com>
---
Notes:
v5:
* Move test_i18ngrep into subshell
t/t5520-pull.sh | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/t/t5520-pull.sh b/t/t5520-pull.sh
index 90728e0..a04f55c 100755
--- a/t/t5520-pull.sh
+++ b/t/t5520-pull.sh
@@ -412,6 +412,21 @@ test_expect_success 'pull --rebase works on branch yet to be born' '
test_cmp expect actual
'
+test_expect_success 'pull --rebase fails on unborn branch with staged changes' '
+ test_when_finished "rm -rf empty_repo2" &&
+ git init empty_repo2 &&
+ (
+ cd empty_repo2 &&
+ echo staged-file >staged-file &&
+ git add staged-file &&
+ test "$(git ls-files)" = staged-file &&
+ test_must_fail git pull --rebase .. master 2>err &&
+ test "$(git ls-files)" = staged-file &&
+ test "$(git show :staged-file)" = staged-file &&
+ test_i18ngrep "unborn branch with changes added to the index" err
+ )
+'
+
test_expect_success 'setup for detecting upstreamed changes' '
mkdir src &&
(cd src &&
--
2.1.4
next prev parent reply other threads:[~2015-05-29 11:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 11:44 [PATCH v5 0/8] Improve git-pull test coverage Paul Tan
2015-05-29 11:44 ` [PATCH v5 1/8] t5520: prevent field splitting in content comparisons Paul Tan
2015-05-29 11:44 ` [PATCH v5 2/8] t5520: test no merge candidates cases Paul Tan
2015-05-29 11:44 ` [PATCH v5 3/8] t5520: test for failure if index has unresolved entries Paul Tan
2015-05-29 11:44 ` [PATCH v5 4/8] t5520: test work tree fast-forward when fetch updates head Paul Tan
2015-05-29 11:44 ` [PATCH v5 5/8] t5520: test --rebase with multiple branches Paul Tan
2015-05-29 11:44 ` Paul Tan [this message]
2015-05-29 11:44 ` [PATCH v5 7/8] t5521: test --dry-run does not make any changes Paul Tan
2015-05-29 11:44 ` [PATCH v5 8/8] t5520: check reflog action in fast-forward merge Paul Tan
2015-05-29 18:08 ` [PATCH v5 0/8] Improve git-pull test coverage Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432899885-25143-7-git-send-email-pyokagan@gmail.com \
--to=pyokagan@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).