git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Karthik Nayak <karthik.188@gmail.com>
To: git@vger.kernel.org
Cc: christian.couder@gmail.com, Matthieu.Moy@grenoble-inp.fr,
	Karthik Nayak <karthik.188@gmail.com>
Subject: [WIP/PATCH v4 2/8] for-each-ref: simplify code
Date: Sat, 30 May 2015 23:23:25 +0530	[thread overview]
Message-ID: <1433008411-8550-2-git-send-email-karthik.188@gmail.com> (raw)
In-Reply-To: <5569EF77.4010300@gmail.com>

In 'grab_single_ref()' remove the extra count variable 'cnt' and
use the variable 'grab_cnt' of structure 'grab_ref_cbdata' directly
instead.

Mentored-by: Christian Couder <christian.couder@gmail.com>
Mentored-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
---
 builtin/for-each-ref.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c
index b33e2de..919d45e 100644
--- a/builtin/for-each-ref.c
+++ b/builtin/for-each-ref.c
@@ -881,7 +881,6 @@ static int grab_single_ref(const char *refname, const unsigned char *sha1, int f
 {
 	struct grab_ref_cbdata *cb = cb_data;
 	struct refinfo *ref;
-	int cnt;
 
 	if (flag & REF_BAD_NAME) {
 		  warning("ignoring ref with broken name %s", refname);
@@ -893,10 +892,8 @@ static int grab_single_ref(const char *refname, const unsigned char *sha1, int f
 
 	ref = new_refinfo(refname, sha1, flag);
 
-	cnt = cb->grab_cnt;
-	REALLOC_ARRAY(cb->grab_array, cnt + 1);
-	cb->grab_array[cnt++] = ref;
-	cb->grab_cnt = cnt;
+	REALLOC_ARRAY(cb->grab_array, cb->grab_cnt + 1);
+	cb->grab_array[cb->grab_cnt++] = ref;
 
 	return 0;
 }
-- 
2.4.2

  parent reply	other threads:[~2015-05-30 17:54 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5569EF77.4010300@gmail.com>
2015-05-30 17:53 ` [WIP/PATCH v4 1/8] for-each-ref: extract helper functions out of grab_single_ref() Karthik Nayak
2015-05-31  2:58   ` Eric Sunshine
2015-05-31  8:11     ` Karthik Nayak
2015-05-31 17:34   ` Junio C Hamano
2015-05-31 17:48     ` Karthik Nayak
2015-05-31 20:39     ` Matthieu Moy
2015-06-01 14:39       ` Junio C Hamano
2015-05-30 17:53 ` Karthik Nayak [this message]
2015-05-30 17:53 ` [WIP/PATCH v4 3/8] for-each-ref: rename 'refinfo' to 'ref_array_item' Karthik Nayak
2015-05-31 17:37   ` Junio C Hamano
2015-05-31 17:48     ` Karthik Nayak
2015-05-30 17:53 ` [WIP/PATCH v4 4/8] for-each-ref: introduce new structures for better organisation Karthik Nayak
2015-05-31  3:14   ` Eric Sunshine
2015-05-31  8:16     ` Karthik Nayak
2015-05-30 17:53 ` [WIP/PATCH v4 5/8] for-each-ref: introduce 'ref_filter_clear_data()' Karthik Nayak
2015-05-31  7:38   ` Christian Couder
2015-05-31  8:20     ` Karthik Nayak
2015-05-30 17:53 ` [WIP/PATCH v4 6/8] for-each-ref: rename some functions and make them public Karthik Nayak
2015-05-31  3:21   ` Eric Sunshine
2015-05-31  8:16     ` Karthik Nayak
2015-05-31  8:04   ` Christian Couder
2015-05-31  8:11     ` Christian Couder
2015-05-31  9:17       ` Karthik Nayak
2015-05-31 14:03         ` Christian Couder
2015-05-31 15:30           ` Karthik Nayak
2015-06-01  6:38           ` Matthieu Moy
2015-06-01 19:28             ` Karthik Nayak
2015-05-31 17:54     ` Junio C Hamano
2015-05-31 17:48   ` Junio C Hamano
2015-05-31 19:34     ` Karthik Nayak
2015-06-01 14:53       ` Junio C Hamano
2015-06-01 19:35         ` Karthik Nayak
2015-05-30 17:53 ` [WIP/PATCH v4 7/8] ref-filter: move code from 'for-each-ref' Karthik Nayak
2015-05-30 17:53 ` [WIP/PATCH v4 8/8] ref-filter: add 'ref-filter.h' Karthik Nayak
2015-05-31  3:43   ` Eric Sunshine
2015-05-31  8:19     ` Karthik Nayak
2015-05-31  8:29       ` Eric Sunshine
2015-05-31  9:12         ` Karthik Nayak
2015-05-31 20:46       ` Matthieu Moy
2015-05-31 20:50         ` Karthik Nayak
2015-05-31 22:34           ` Christian Couder
2015-06-01  6:47           ` Matthieu Moy
2015-05-31  8:20   ` Christian Couder
2015-05-31  9:16     ` Karthik Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433008411-8550-2-git-send-email-karthik.188@gmail.com \
    --to=karthik.188@gmail.com \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).