git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tay Ray Chuan <rctay89@gmail.com>
To: "Git Mailing List" <git@vger.kernel.org>
Cc: "Junio C Hamano" <gitster@pobox.com>
Subject: [PATCH v2 0/2] make commit --verbose work with --no-status
Date: Fri,  5 Jun 2015 01:56:29 +0800	[thread overview]
Message-ID: <1433440591-30917-1-git-send-email-rctay89@gmail.com> (raw)

When running git-commit`, --verbose appends a diff to the prepared
message, while --no-status omits git-status output; thus, one would
expect --verbose --no-status to give a commit message with a diff of
the commit without git-status output.

However, this is not what happens - the prepared commit message body is
empty, entirely. (Needless to say, no diff is appended.) This patch
series attempts to make this work, as one would expect.

[PATCH 1/2] extract setting of wt_status.commitable flag out of
wt_status_print_updated()

Currently, the wt_status.commitable flag is set only when we call
wt_status_print(). * Extract this logic, so that we don't have to go
through the git-status output code just to set the flag.

* In fact, it is not set when --short or --porcelain are used. This
  series does not attempt to fix the bug, though it should be trivial to
  do so with this patch. See 9cbcc2a (demonstrate git-commit --dry-run
  exit code behaviour, Feb 22 2014).

[PATCH 2/2] make commit --verbose work with --no-status

Actual work here.

-- 
2.0.0.581.g64f2558

             reply	other threads:[~2015-06-04 17:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-04 17:56 Tay Ray Chuan [this message]
2015-06-04 17:56 ` [PATCH v2 1/2] extract setting of wt_status.commitable flag out of wt_status_print_updated() Tay Ray Chuan
2015-06-04 17:56   ` [PATCH v2 2/2] make commit --verbose work with --no-status Tay Ray Chuan
2015-06-04 21:34   ` [PATCH v2 1/2] extract setting of wt_status.commitable flag out of wt_status_print_updated() Junio C Hamano
2015-06-04 18:39 ` [PATCH v2 0/2] make commit --verbose work with --no-status Junio C Hamano
2015-06-05 12:40   ` Tay Ray Chuan
2015-06-05 16:03     ` Junio C Hamano
2015-06-05 16:48       ` Tay Ray Chuan
2015-06-05 17:13         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433440591-30917-1-git-send-email-rctay89@gmail.com \
    --to=rctay89@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).