From: Mike Edgar <adgar@google.com>
To: git@vger.kernel.org
Cc: peff@peff.net, pclouds@gmail.com, Mike Edgar <adgar@google.com>
Subject: [PATCH] clone: check if server supports shallow clones
Date: Wed, 10 Jun 2015 14:35:20 -0400 [thread overview]
Message-ID: <1433961320-1366-1-git-send-email-adgar@google.com> (raw)
When the user passes --depth to git-clone the server's capabilities are
not currently consulted. The client will send shallow requests even if
the server does not understand them, and the resulting error may be
unhelpful to the user. This change pre-emptively checks so git-clone can
exit with a helpful error if necessary.
Signed-off-by: Mike Edgar <adgar@google.com>
---
builtin/clone.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/builtin/clone.c b/builtin/clone.c
index b878252..b4e9846 100644
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -944,6 +944,9 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
refs = transport_get_remote_refs(transport);
+ if (option_depth && !is_local && !server_supports("shallow"))
+ die(_("Server does not support shallow clients"));
+
if (refs) {
mapped_refs = wanted_peer_refs(refs, refspec);
/*
--
2.2.0.rc0.207.ga3a616c
next reply other threads:[~2015-06-10 18:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 18:35 Mike Edgar [this message]
2015-06-10 19:05 ` [PATCH] clone: check if server supports shallow clones Jeff King
2015-06-10 20:25 ` Michael Edgar
2015-06-10 20:56 ` Jeff King
2015-06-11 13:02 ` Duy Nguyen
2015-06-11 14:32 ` Jeff King
2015-06-11 18:18 ` Michael Edgar
2015-06-11 20:44 ` Junio C Hamano
2015-06-17 11:48 ` [PATCH v2] fetch-pack: check for shallow if depth given Mike Edgar
2015-06-17 17:00 ` Jeff King
2015-06-17 16:35 ` [PATCH] clone: check if server supports shallow clones Junio C Hamano
2015-06-17 16:59 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433961320-1366-1-git-send-email-adgar@google.com \
--to=adgar@google.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).