git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Karthik Nayak <karthik.188@gmail.com>
To: git@vger.kernel.org
Cc: christian.couder@gmail.com, Matthieu.Moy@grenoble-inp.fr,
	Karthik Nayak <karthik.188@gmail.com>
Subject: [PATCH v7 08/12] for-each-ref: rename variables called sort to sorting
Date: Thu, 11 Jun 2015 21:39:59 +0530	[thread overview]
Message-ID: <1434039003-10928-8-git-send-email-karthik.188@gmail.com> (raw)
In-Reply-To: <1434039003-10928-1-git-send-email-karthik.188@gmail.com>

Rename all the variables called sort to sorting to match the
function/structure name changes made in the previous patch.

Mentored-by: Christian Couder <christian.couder@gmail.com>
Mentored-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
---
 builtin/for-each-ref.c | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c
index 4a6eaba..3cf456a 100644
--- a/builtin/for-each-ref.c
+++ b/builtin/for-each-ref.c
@@ -985,9 +985,9 @@ static int compare_refs(const void *a_, const void *b_)
 	return 0;
 }
 
-void ref_array_sort(struct ref_sorting *sort, struct ref_array *array)
+void ref_array_sort(struct ref_sorting *sorting, struct ref_array *array)
 {
-	ref_sorting = sort;
+	ref_sorting = sorting;
 	qsort(array->items, array->nr, sizeof(struct ref_array_item *), compare_refs);
 }
 
@@ -1089,16 +1089,16 @@ struct ref_sorting *ref_default_sorting(void)
 {
 	static const char cstr_name[] = "refname";
 
-	struct ref_sorting *sort = xcalloc(1, sizeof(*sort));
+	struct ref_sorting *sorting = xcalloc(1, sizeof(*sorting));
 
-	sort->next = NULL;
-	sort->atom = parse_ref_filter_atom(cstr_name, cstr_name + strlen(cstr_name));
-	return sort;
+	sorting->next = NULL;
+	sorting->atom = parse_ref_filter_atom(cstr_name, cstr_name + strlen(cstr_name));
+	return sorting;
 }
 
 int parse_opt_ref_sorting(const struct option *opt, const char *arg, int unset)
 {
-	struct ref_sorting **sort_tail = opt->value;
+	struct ref_sorting **sorting_tail = opt->value;
 	struct ref_sorting *s;
 	int len;
 
@@ -1106,8 +1106,8 @@ int parse_opt_ref_sorting(const struct option *opt, const char *arg, int unset)
 		return -1;
 
 	s = xcalloc(1, sizeof(*s));
-	s->next = *sort_tail;
-	*sort_tail = s;
+	s->next = *sorting_tail;
+	*sorting_tail = s;
 
 	if (*arg == '-') {
 		s->reverse = 1;
@@ -1127,7 +1127,7 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix)
 {
 	int i;
 	const char *format = "%(objectname) %(objecttype)\t%(refname)";
-	struct ref_sorting *sort = NULL, **sort_tail = &sort;
+	struct ref_sorting *sorting = NULL, **sorting_tail = &sorting;
 	int maxcount = 0, quote_style = 0;
 	struct ref_filter_cbdata ref_cbdata;
 
@@ -1144,7 +1144,7 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix)
 		OPT_GROUP(""),
 		OPT_INTEGER( 0 , "count", &maxcount, N_("show only <n> matched refs")),
 		OPT_STRING(  0 , "format", &format, N_("format"), N_("format to use for the output")),
-		OPT_CALLBACK(0 , "sort", sort_tail, N_("key"),
+		OPT_CALLBACK(0 , "sort", sorting_tail, N_("key"),
 			    N_("field name to sort on"), &parse_opt_ref_sorting),
 		OPT_END(),
 	};
@@ -1161,8 +1161,8 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix)
 	if (verify_ref_format(format))
 		usage_with_options(for_each_ref_usage, opts);
 
-	if (!sort)
-		sort = ref_default_sorting();
+	if (!sorting)
+		sorting = ref_default_sorting();
 
 	/* for warn_ambiguous_refs */
 	git_config(git_default_config, NULL);
@@ -1171,7 +1171,7 @@ int cmd_for_each_ref(int argc, const char **argv, const char *prefix)
 	ref_cbdata.filter.name_patterns = argv;
 	for_each_rawref(ref_filter_handler, &ref_cbdata);
 
-	ref_array_sort(sort, &ref_cbdata.array);
+	ref_array_sort(sorting, &ref_cbdata.array);
 
 	if (!maxcount || ref_cbdata.array.nr < maxcount)
 		maxcount = ref_cbdata.array.nr;
-- 
2.4.2

  parent reply	other threads:[~2015-06-11 16:23 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-11 16:07 [PATCH v7 0/12] Create ref-filter from for-each-ref Karthik Nayak
2015-06-11 16:09 ` [PATCH v7 01/12] for-each-ref: extract helper functions out of grab_single_ref() Karthik Nayak
2015-06-11 16:09   ` [PATCH v7 02/12] for-each-ref: clean up code Karthik Nayak
2015-06-11 16:09   ` [PATCH v7 03/12] for-each-ref: change comment in ref_sort Karthik Nayak
2015-06-12 17:40     ` Junio C Hamano
2015-06-12 17:48       ` Karthik Nayak
2015-06-12 18:04         ` Junio C Hamano
2015-06-12 18:29           ` Karthik Nayak
2015-06-12 19:49             ` Christian Couder
2015-06-12 20:27               ` Junio C Hamano
2015-06-12 21:22                 ` karthik nayak
2015-06-11 16:09   ` [PATCH v7 04/12] for-each-ref: rename 'refinfo' to 'ref_array_item' Karthik Nayak
2015-06-11 16:09   ` [PATCH v7 05/12] for-each-ref: introduce new structures for better organisation Karthik Nayak
2015-06-11 17:41     ` Matthieu Moy
2015-06-11 17:56       ` Karthik Nayak
2015-06-11 19:13         ` Matthieu Moy
2015-06-11 19:21           ` Karthik Nayak
2015-06-11 19:47             ` Matthieu Moy
2015-06-11 16:09   ` [PATCH v7 06/12] for-each-ref: introduce 'ref_array_clear()' Karthik Nayak
2015-06-11 16:09   ` [PATCH v7 07/12] for-each-ref: rename some functions and make them public Karthik Nayak
2015-06-11 16:09   ` Karthik Nayak [this message]
2015-06-11 16:10   ` [PATCH v7 09/12] ref-filter: add 'ref-filter.h' Karthik Nayak
2015-06-11 16:10   ` [PATCH v7 10/12] ref-filter: move code from 'for-each-ref' Karthik Nayak
2015-06-11 16:10   ` [PATCH v7 11/12] for-each-ref: introduce filter_refs() Karthik Nayak
2015-06-11 17:00     ` Matthieu Moy
2015-06-11 17:17       ` Karthik Nayak
2015-06-12 19:38       ` Junio C Hamano
2015-06-11 17:21     ` Karthik Nayak
2015-06-11 16:10   ` [PATCH v7 12/12] ref-filter: make 'ref_array_item' use a FLEX_ARRAY for refname Karthik Nayak
2015-06-12 17:30   ` [PATCH v7 01/12] for-each-ref: extract helper functions out of grab_single_ref() Junio C Hamano
2015-06-12 17:32     ` Karthik Nayak
2015-06-11 17:03 ` [PATCH v7 0/12] Create ref-filter from for-each-ref Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434039003-10928-8-git-send-email-karthik.188@gmail.com \
    --to=karthik.188@gmail.com \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).