git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Hansen <rhansen@bbn.com>
To: git@vger.kernel.org, gitster@pobox.com, peff@peff.net
Cc: Richard Hansen <rhansen@bbn.com>
Subject: [PATCH v2 0/2] redo fix for test-lib.sh color support
Date: Wed, 17 Jun 2015 17:11:19 -0400	[thread overview]
Message-ID: <1434575481-24604-1-git-send-email-rhansen@bbn.com> (raw)
In-Reply-To: <xmqqvbem5bx9.fsf@gitster.dls.corp.google.com>

Changes from v1:
  * Eliminate the case statement and assume the user passed a sane
    value for $1.
  * Use the same test as the non-colorized version of say_color() when
    determining whether to suppress the output:  assume that a message
    can only be suppresed if $1 is the empty string.  This avoids the
    need to test whether the variable say_color_$1 is set.
  * Rename say_color_sgr0 to say_color_reset.
  * Add a new variable say_color_ (set to the empty string) as a way
    of documenting that $1 is expected to be the empty string for
    normal text.

Richard Hansen (2):
  Revert "test-lib.sh: do tests for color support after changing HOME"
  test-lib.sh: fix color support when tput needs ~/.terminfo

 t/test-lib.sh | 99 ++++++++++++++++++++++++++++-------------------------------
 1 file changed, 47 insertions(+), 52 deletions(-)

-- 
2.4.3

  reply	other threads:[~2015-06-17 21:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-17 19:06 [PATCH 0/2] redo fix for test-lib.sh color support Richard Hansen
2015-06-17 19:06 ` [PATCH 1/2] Revert "test-lib.sh: do tests for color support after changing HOME" Richard Hansen
2015-06-17 19:06 ` [PATCH 2/2] test-lib.sh: fix color support when tput needs ~/.terminfo Richard Hansen
2015-06-17 19:43   ` Jeff King
2015-06-17 19:55     ` Richard Hansen
2015-06-17 20:15       ` Junio C Hamano
2015-06-17 21:11         ` Richard Hansen [this message]
2015-06-17 21:11           ` [PATCH v2 1/2] Revert "test-lib.sh: do tests for color support after changing HOME" Richard Hansen
2015-06-17 21:11           ` [PATCH v2 2/2] test-lib.sh: fix color support when tput needs ~/.terminfo Richard Hansen
2015-06-17 22:13             ` Jeff King
2015-06-17 22:23               ` Junio C Hamano
2015-06-17 22:26                 ` Jeff King
2015-06-17 20:25       ` [PATCH " Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434575481-24604-1-git-send-email-rhansen@bbn.com \
    --to=rhansen@bbn.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).