From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Turner Subject: [PATCH v5 4/7] refs: Break out check for reflog autocreation Date: Mon, 29 Jun 2015 13:54:25 -0400 Message-ID: <1435600468-21710-5-git-send-email-dturner@twopensource.com> References: <1435600468-21710-1-git-send-email-dturner@twopensource.com> Cc: David Turner To: git@vger.kernel.org, mhagger@alum.mit.edu X-From: git-owner@vger.kernel.org Mon Jun 29 19:54:57 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z9dGj-0005tS-7m for gcvg-git-2@plane.gmane.org; Mon, 29 Jun 2015 19:54:57 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753110AbbF2Ryw (ORCPT ); Mon, 29 Jun 2015 13:54:52 -0400 Received: from mail-qg0-f49.google.com ([209.85.192.49]:34499 "EHLO mail-qg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752950AbbF2Ryn (ORCPT ); Mon, 29 Jun 2015 13:54:43 -0400 Received: by qgii30 with SMTP id i30so9498384qgi.1 for ; Mon, 29 Jun 2015 10:54:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vScemfqiGziU1XjhSdtU2pz9r0kl8Th9lRvqPqfet80=; b=FROyFbflueaFMnOCnV+I0rPGmGavNGJv2qSGAcEqLM+U8GNL19bx+oLITrMTK4fZlB dqNSA3Vug/OjytDVQuUzoDHT9vCCQP+j9EaKod+Uu9YALc7CbBJqY8Vdr8troLLWlxXb 0NzbBttnrfojCXdqNV8zIqgcEYa+7ZBQAZrtNejkO59+xmvKqKL9HKRoBPjcJhLuAQt7 3yDlprPCeGNzrqIPxg8bawppD0bvV3+UReOlc/rUBglcCYrgO7O7TQ8tdFeO7HrP2Apk OFYMubKxhQxHzI+pktTlJdkjoxcFQi8TP8qP8WkZ7hrOat1megb1uO4DynSRNSDCGyd6 riIg== X-Gm-Message-State: ALoCoQm/TZmPuVpcfu+My3aFf1errj7/NdSc3AmBg05qSJy7UCPPBt7eSPvVJ3bkPKfuApoPbP7p X-Received: by 10.140.87.5 with SMTP id q5mr20314325qgd.3.1435600482398; Mon, 29 Jun 2015 10:54:42 -0700 (PDT) Received: from ubuntu.jfk4.office.twttr.net ([192.133.79.145]) by mx.google.com with ESMTPSA id w67sm11860026qgw.41.2015.06.29.10.54.40 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 29 Jun 2015 10:54:41 -0700 (PDT) X-Mailer: git-send-email 2.0.4.315.gad8727a-twtrsrc In-Reply-To: <1435600468-21710-1-git-send-email-dturner@twopensource.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: This is just for clarity. Signed-off-by: David Turner --- refs.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/refs.c b/refs.c index b34a54a..dd76721 100644 --- a/refs.c +++ b/refs.c @@ -3118,6 +3118,16 @@ static int copy_msg(char *buf, const char *msg) return cp - buf; } +static int should_autocreate_reflog(const char *refname) +{ + if (!log_all_ref_updates) + return 0; + return starts_with(refname, "refs/heads/") || + starts_with(refname, "refs/remotes/") || + starts_with(refname, "refs/notes/") || + !strcmp(refname, "HEAD"); +} + /* This function will fill in *err and return -1 on failure */ int log_ref_setup(const char *refname, struct strbuf *sb_logfile, struct strbuf *err) { @@ -3128,11 +3138,7 @@ int log_ref_setup(const char *refname, struct strbuf *sb_logfile, struct strbuf logfile = sb_logfile->buf; /* make sure the rest of the function can't change "logfile" */ sb_logfile = NULL; - if (log_all_ref_updates && - (starts_with(refname, "refs/heads/") || - starts_with(refname, "refs/remotes/") || - starts_with(refname, "refs/notes/") || - !strcmp(refname, "HEAD"))) { + if (should_autocreate_reflog(refname)) { if (safe_create_leading_directories(logfile) < 0) { strbuf_addf(err, "unable to create directory for %s. " "%s", logfile, strerror(errno)); -- 2.0.4.315.gad8727a-twtrsrc