From: David Turner <dturner@twopensource.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>, git@vger.kernel.org
Subject: Re: [PATCH] log: add log.follow config option
Date: Thu, 02 Jul 2015 14:43:37 -0400 [thread overview]
Message-ID: <1435862617.30946.2.camel@twopensource.com> (raw)
In-Reply-To: <xmqqvbe37eyy.fsf@gitster.dls.corp.google.com>
On Wed, 2015-07-01 at 14:19 -0700, Junio C Hamano wrote:
> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
> > So activating --follow for all "git log" calls would prevent log from
> > being used with several pathspecs.
> >
> > Or, do you have a preparation patch that allows --follow with multiple
> > pathspecs? ;-)
> >
> > In any case, you have to test "git log -- path1 path2" with the option
> > activated.
>
> Or more commonly, just "git log" with no pathspec.
>
> I also think that it is a bad idea to force "log --follow" to people
> before it is made into a true feature; as it stands, it is merely a
> "checkbox" item. It has too severe limitation to be used seriously
> in real projects, unless your history is completely linear.
>
> cf.
>
> http://thread.gmane.org/gmane.comp.version-control.git/269357/focus=269433
Thanks.
Twitter's history is almost completely linear, so it's useful for us.
Since it looks like the patch won't be useful outside of our context,
I'll just rewrite it to check the pathspec count, and not upstream it
until follow becomes more general.
next prev parent reply other threads:[~2015-07-02 18:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-01 19:03 [PATCH] log: add log.follow config option David Turner
2015-07-01 21:16 ` Matthieu Moy
2015-07-01 21:19 ` Junio C Hamano
2015-07-02 18:43 ` David Turner [this message]
2015-07-03 7:17 ` Matthieu Moy
2015-07-03 17:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435862617.30946.2.camel@twopensource.com \
--to=dturner@twopensource.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).