git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <git@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: [PATCH] git-am: flag suspiciously old or futuristic commits
Date: Wed, 29 Jul 2015 18:01:37 -0400	[thread overview]
Message-ID: <1438207297-11686-1-git-send-email-paul.gortmaker@windriver.com> (raw)

The linux kernel repository has some commits in it with dates from
the year 1970 and also 2030 (and possibly others).  We probably shouldi
warn people when the dates look suspect.

For commits in the future,  note that a committer in Australia
could commit on New Years Day, and send it to a maintainer in North
America and that would trip the notification on the maintainer's
New Years Eve.  But that is unlikely, and the note is still
correct; that the commit is from a future year.

For commits in the past, I chose a somewhat arbitrary 30 year
limit, which will allow stuff from post 1985; the thought being
that someone might want to import an old repo into git from some
other SCM.  We could alternatively set it to 5, which would then
catch computers with a dead CMOS battery, at the risk of pestering
the hypothetical museum curator of old bits.

Sample output:

paul@builder:~/git/linux-head$ grep Date: *patch
future.patch:Date: Sat, 18 Jul 2037 21:22:19 -0400
past.patch:Date: Sat, 18 Jul 1977 21:22:19 -0400

paul@builder:~/git/linux-head$ git am future.patch
note: commit is from future year 2037.
Applying: arch/sh: make heartbeat driver explicitly non-modular
paul@builder:~/git/linux-head$ git reset --hard HEAD~ > /dev/null
paul@builder:~/git/linux-head$ git am past.patch
note: commit is from implausibly old year 1977.
Applying: arch/sh: make heartbeat driver explicitly non-modular
paul@builder:~/git/linux-head$

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 git-am.sh | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/git-am.sh b/git-am.sh
index 3af351ffaaf3..ff6deb8047a4 100755
--- a/git-am.sh
+++ b/git-am.sh
@@ -766,6 +766,21 @@ To restore the original branch and stop patching run \"\$cmdline --abort\"."
 		stop_here $this
 	fi
 
+	if test -n "$GIT_AUTHOR_DATE"
+	then
+		THIS_YEAR=`date +%Y`
+		TOO_OLD=$(expr $THIS_YEAR - 30)
+		TOO_NEW=$(expr $THIS_YEAR + 1)
+		GIT_AUTHOR_YEAR=`date -d "$GIT_AUTHOR_DATE" +%Y`
+
+		if [ "$GIT_AUTHOR_YEAR" -le "$TOO_OLD" ]; then
+			say "$(gettext "note: commit is from implausibly old year $GIT_AUTHOR_YEAR.")"
+		fi
+		if [ "$GIT_AUTHOR_YEAR" -ge "$TOO_NEW" ]; then
+			say "$(gettext "note: commit is from future year $GIT_AUTHOR_YEAR.")"
+		fi
+	fi
+
 	export GIT_AUTHOR_NAME GIT_AUTHOR_EMAIL GIT_AUTHOR_DATE
 
 	case "$resume" in
-- 
2.5.0

             reply	other threads:[~2015-07-29 22:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-29 22:01 Paul Gortmaker [this message]
2015-07-29 22:20 ` [PATCH] git-am: flag suspiciously old or futuristic commits Stefan Beller
2015-07-30  4:35   ` Jacob Keller
2015-07-30 15:07     ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438207297-11686-1-git-send-email-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).