From mboxrd@z Thu Jan 1 00:00:00 1970 From: Karthik Nayak Subject: [PATCH v8 01/11] ref-filter: print output to strbuf for formatting Date: Mon, 3 Aug 2015 22:24:11 +0530 Message-ID: <1438620861-25219-1-git-send-email-Karthik.188@gmail.com> References: Cc: christian.couder@gmail.com, Matthieu.Moy@grenoble-inp.fr, gitster@pobox.com, Karthik Nayak To: git@vger.kernel.org X-From: git-owner@vger.kernel.org Mon Aug 03 18:54:26 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZMJ0L-0000Il-ND for gcvg-git-2@plane.gmane.org; Mon, 03 Aug 2015 18:54:26 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754556AbbHCQyV (ORCPT ); Mon, 3 Aug 2015 12:54:21 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:33800 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754190AbbHCQyV (ORCPT ); Mon, 3 Aug 2015 12:54:21 -0400 Received: by pdbbo16 with SMTP id bo16so18655956pdb.1 for ; Mon, 03 Aug 2015 09:54:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ECqzWk/h4l3PjXGxel851lGxGmmfbvglFAmUVl9kABg=; b=t/35xtHhkOQzEN8FyHn3BnAIVlEItqRGCHqXpssjHi7QPVfKhfGHf5GhinmuPQiW/o WYOVdMHhLb7BNJyX0mT1ASiV4OXdP7PZxurxrE5oc5fzsSAf44xvRmB3w0CBNOPXao4a QlzOlNK4ZM+YOb8YrjNGlILKOLV/k9kFyVg6nRDe3+s6r2sqEHkPPoTGrIvGFGLKXKa6 WNe370nPTxt83B/Raz2Br1Uo0X7jjM6mxzDT2VjMzCXVSTjLJAkJLkjp0Srjb0EP4n/U xXr1uB/igB56by661yyybI1/x9VhADDOOCREaIqotavnS4KMXWSCPTlJbZ0NVVRdG5qQ B9aA== X-Received: by 10.70.128.14 with SMTP id nk14mr38067240pdb.79.1438620860706; Mon, 03 Aug 2015 09:54:20 -0700 (PDT) Received: from ashley.localdomain ([106.51.130.23]) by smtp.gmail.com with ESMTPSA id gk5sm18164153pac.21.2015.08.03.09.54.17 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Aug 2015 09:54:19 -0700 (PDT) X-Google-Original-From: Karthik Nayak X-Mailer: git-send-email 2.4.6 In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Introduce a strbuf `output` which will act as a substitute rather than printing directly to stdout. This will be used for formatting eventually. --- ref-filter.c | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/ref-filter.c b/ref-filter.c index 7561727..febdc45 100644 --- a/ref-filter.c +++ b/ref-filter.c @@ -1190,30 +1190,25 @@ void ref_array_sort(struct ref_sorting *sorting, struct ref_array *array) qsort(array->items, array->nr, sizeof(struct ref_array_item *), compare_refs); } -static void print_value(struct atom_value *v, int quote_style) +static void print_value(struct atom_value *v, int quote_style, struct strbuf *output) { - struct strbuf sb = STRBUF_INIT; switch (quote_style) { case QUOTE_NONE: - fputs(v->s, stdout); + strbuf_addstr(output, v->s); break; case QUOTE_SHELL: - sq_quote_buf(&sb, v->s); + sq_quote_buf(output, v->s); break; case QUOTE_PERL: - perl_quote_buf(&sb, v->s); + perl_quote_buf(output, v->s); break; case QUOTE_PYTHON: - python_quote_buf(&sb, v->s); + python_quote_buf(output, v->s); break; case QUOTE_TCL: - tcl_quote_buf(&sb, v->s); + tcl_quote_buf(output, v->s); break; } - if (quote_style != QUOTE_NONE) { - fputs(sb.buf, stdout); - strbuf_release(&sb); - } } static int hex1(char ch) @@ -1234,7 +1229,7 @@ static int hex2(const char *cp) return -1; } -static void emit(const char *cp, const char *ep) +static void emit(const char *cp, const char *ep, struct strbuf *output) { while (*cp && (!ep || cp < ep)) { if (*cp == '%') { @@ -1243,13 +1238,13 @@ static void emit(const char *cp, const char *ep) else { int ch = hex2(cp + 1); if (0 <= ch) { - putchar(ch); + strbuf_addch(output, ch); cp += 3; continue; } } } - putchar(*cp); + strbuf_addch(output, *cp); cp++; } } @@ -1257,19 +1252,21 @@ static void emit(const char *cp, const char *ep) void show_ref_array_item(struct ref_array_item *info, const char *format, int quote_style) { const char *cp, *sp, *ep; + struct strbuf output = STRBUF_INIT; + int i; for (cp = format; *cp && (sp = find_next(cp)); cp = ep + 1) { struct atom_value *atomv; ep = strchr(sp, ')'); if (cp < sp) - emit(cp, sp); + emit(cp, sp, &output); get_ref_atom_value(info, parse_ref_filter_atom(sp + 2, ep), &atomv); - print_value(atomv, quote_style); + print_value(atomv, quote_style, &output); } if (*cp) { sp = cp + strlen(cp); - emit(cp, sp); + emit(cp, sp, &output); } if (need_color_reset_at_eol) { struct atom_value resetv; @@ -1278,9 +1275,12 @@ void show_ref_array_item(struct ref_array_item *info, const char *format, int qu if (color_parse("reset", color) < 0) die("BUG: couldn't parse 'reset' as a color"); resetv.s = color; - print_value(&resetv, quote_style); + print_value(&resetv, quote_style, &output); } + for (i = 0; i < output.len; i++) + printf("%c", output.buf[i]); putchar('\n'); + strbuf_release(&output); } /* If no sorting option is given, use refname to sort as default */ -- 2.4.6