From: Paul Tan <pyokagan@gmail.com>
To: git@vger.kernel.org
Cc: Stefan Beller <sbeller@google.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Paul Tan <pyokagan@gmail.com>
Subject: [PATCH v7 24/45] builtin-am: implement -u/--utf8
Date: Tue, 4 Aug 2015 21:51:45 +0800 [thread overview]
Message-ID: <1438696326-19590-25-git-send-email-pyokagan@gmail.com> (raw)
In-Reply-To: <1438696326-19590-1-git-send-email-pyokagan@gmail.com>
Since d1c5f2a (Add git-am, applymbox replacement., 2005-10-07),
git-am.sh supported the -u,--utf8 option. If set, the -u option will be
passed to git-mailinfo to re-code the commit log message and authorship
in the charset specified by i18n.commitencoding. If unset, the -n option
will be passed to git-mailinfo, which disables the re-encoding.
Since d84029b (--utf8 is now default for 'git-am', 2007-01-08), --utf8
is specified by default in git-am.sh.
Re-implement the above in builtin/am.c.
Signed-off-by: Paul Tan <pyokagan@gmail.com>
---
builtin/am.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/builtin/am.c b/builtin/am.c
index 47dd4c7..528b2c9 100644
--- a/builtin/am.c
+++ b/builtin/am.c
@@ -90,6 +90,7 @@ struct am_state {
int threeway;
int quiet;
int signoff;
+ int utf8;
const char *resolvemsg;
int rebasing;
};
@@ -106,6 +107,8 @@ static void am_state_init(struct am_state *state, const char *dir)
state->dir = xstrdup(dir);
state->prec = 4;
+
+ state->utf8 = 1;
}
/**
@@ -367,6 +370,9 @@ static void am_load(struct am_state *state)
read_state_file(&sb, state, "sign", 1);
state->signoff = !strcmp(sb.buf, "t");
+ read_state_file(&sb, state, "utf8", 1);
+ state->utf8 = !strcmp(sb.buf, "t");
+
state->rebasing = !!file_exists(am_path(state, "rebasing"));
strbuf_release(&sb);
@@ -556,6 +562,8 @@ static void am_setup(struct am_state *state, enum patch_format patch_format,
write_file(am_path(state, "sign"), 1, state->signoff ? "t" : "f");
+ write_file(am_path(state, "utf8"), 1, state->utf8 ? "t" : "f");
+
if (state->rebasing)
write_file(am_path(state, "rebasing"), 1, "%s", "");
else
@@ -722,6 +730,7 @@ static int parse_mail(struct am_state *state, const char *mail)
cp.out = xopen(am_path(state, "info"), O_WRONLY | O_CREAT, 0777);
argv_array_push(&cp.args, "mailinfo");
+ argv_array_push(&cp.args, state->utf8 ? "-u" : "-n");
argv_array_push(&cp.args, am_path(state, "msg"));
argv_array_push(&cp.args, am_path(state, "patch"));
@@ -1460,6 +1469,8 @@ int cmd_am(int argc, const char **argv, const char *prefix)
OPT__QUIET(&state.quiet, N_("be quiet")),
OPT_BOOL('s', "signoff", &state.signoff,
N_("add a Signed-off-by line to the commit message")),
+ OPT_BOOL('u', "utf8", &state.utf8,
+ N_("recode into utf8 (default)")),
OPT_CALLBACK(0, "patch-format", &patch_format, N_("format"),
N_("format the patch(es) are in"),
parse_opt_patchformat),
--
2.5.0.280.gd88bd6e
next prev parent reply other threads:[~2015-08-04 13:54 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 13:51 [PATCH v7 00/45] Make git-am a builtin Paul Tan
2015-08-04 13:51 ` [PATCH v7 01/45] wrapper: implement xopen() Paul Tan
2015-08-04 13:51 ` [PATCH v7 02/45] wrapper: implement xfopen() Paul Tan
2015-08-04 13:51 ` [PATCH v7 03/45] builtin-am: implement skeletal builtin am Paul Tan
2015-08-04 13:51 ` [PATCH v7 04/45] builtin-am: implement patch queue mechanism Paul Tan
2015-08-04 13:51 ` [PATCH v7 05/45] builtin-am: split out mbox/maildir patches with git-mailsplit Paul Tan
2015-08-04 13:51 ` [PATCH v7 06/45] builtin-am: auto-detect mbox patches Paul Tan
2015-08-04 13:51 ` [PATCH v7 07/45] builtin-am: extract patch and commit info with git-mailinfo Paul Tan
2015-08-04 13:51 ` [PATCH v7 08/45] builtin-am: apply patch with git-apply Paul Tan
2015-08-04 13:51 ` [PATCH v7 09/45] builtin-am: implement committing applied patch Paul Tan
2015-08-04 13:51 ` [PATCH v7 10/45] builtin-am: refuse to apply patches if index is dirty Paul Tan
2015-08-04 13:51 ` [PATCH v7 11/45] builtin-am: implement --resolved/--continue Paul Tan
2015-08-04 13:51 ` [PATCH v7 12/45] builtin-am: don't parse mail when resuming Paul Tan
2015-08-04 13:51 ` [PATCH v7 13/45] builtin-am: implement --skip Paul Tan
2015-08-04 13:51 ` [PATCH v7 14/45] builtin-am: implement --abort Paul Tan
2015-08-04 13:51 ` [PATCH v7 15/45] builtin-am: reject patches when there's a session in progress Paul Tan
2015-08-04 13:51 ` [PATCH v7 16/45] builtin-am: implement -q/--quiet Paul Tan
2015-08-04 13:51 ` [PATCH v7 17/45] builtin-am: exit with user friendly message on failure Paul Tan
2015-08-04 13:51 ` [PATCH v7 18/45] builtin-am: implement -s/--signoff Paul Tan
2015-08-04 13:51 ` [PATCH v7 19/45] cache-tree: introduce write_index_as_tree() Paul Tan
2015-08-04 13:51 ` [PATCH v7 20/45] builtin-am: implement --3way Paul Tan
2015-08-04 13:51 ` [PATCH v7 21/45] builtin-am: implement --rebasing mode Paul Tan
2015-08-04 13:51 ` [PATCH v7 22/45] builtin-am: bypass git-mailinfo when --rebasing Paul Tan
2015-08-04 13:51 ` [PATCH v7 23/45] builtin-am: handle stray state directory Paul Tan
2015-08-04 13:51 ` Paul Tan [this message]
2015-08-04 13:51 ` [PATCH v7 25/45] builtin-am: implement -k/--keep, --keep-non-patch Paul Tan
2015-08-04 13:51 ` [PATCH v7 26/45] builtin-am: implement --[no-]message-id, am.messageid Paul Tan
2015-08-04 13:51 ` [PATCH v7 27/45] builtin-am: support --keep-cr, am.keepcr Paul Tan
2015-08-04 13:51 ` [PATCH v7 28/45] builtin-am: implement --[no-]scissors Paul Tan
2015-08-04 13:51 ` [PATCH v7 29/45] builtin-am: pass git-apply's options to git-apply Paul Tan
2015-08-04 13:51 ` [PATCH v7 30/45] builtin-am: implement --ignore-date Paul Tan
2015-08-04 13:51 ` [PATCH v7 31/45] builtin-am: implement --committer-date-is-author-date Paul Tan
2015-08-04 13:51 ` [PATCH v7 32/45] builtin-am: implement -S/--gpg-sign, commit.gpgsign Paul Tan
2015-08-04 13:51 ` [PATCH v7 33/45] builtin-am: invoke post-rewrite hook Paul Tan
2015-08-04 13:51 ` [PATCH v7 34/45] builtin-am: support automatic notes copying Paul Tan
2015-08-04 13:51 ` [PATCH v7 35/45] builtin-am: invoke applypatch-msg hook Paul Tan
2015-08-04 13:51 ` [PATCH v7 36/45] builtin-am: invoke pre-applypatch hook Paul Tan
2015-08-04 13:51 ` [PATCH v7 37/45] builtin-am: invoke post-applypatch hook Paul Tan
2015-08-04 13:51 ` [PATCH v7 38/45] builtin-am: rerere support Paul Tan
2015-08-04 13:52 ` [PATCH v7 39/45] builtin-am: support and auto-detect StGit patches Paul Tan
2015-08-04 13:52 ` [PATCH v7 40/45] builtin-am: support and auto-detect StGit series files Paul Tan
2015-08-04 13:52 ` [PATCH v7 41/45] builtin-am: support and auto-detect mercurial patches Paul Tan
2015-08-04 13:52 ` [PATCH v7 42/45] builtin-am: implement -i/--interactive Paul Tan
2015-08-04 13:52 ` [PATCH v7 43/45] builtin-am: implement legacy -b/--binary option Paul Tan
2015-08-04 13:52 ` [PATCH v7 44/45] builtin-am: check for valid committer ident Paul Tan
2015-08-04 13:52 ` [PATCH v7 45/45] builtin-am: remove redirection to git-am.sh Paul Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438696326-19590-25-git-send-email-pyokagan@gmail.com \
--to=pyokagan@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).