From: Paul Tan <pyokagan@gmail.com>
To: git@vger.kernel.org
Cc: Stefan Beller <sbeller@google.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Paul Tan <pyokagan@gmail.com>
Subject: [PATCH v7 29/45] builtin-am: pass git-apply's options to git-apply
Date: Tue, 4 Aug 2015 21:51:50 +0800 [thread overview]
Message-ID: <1438696326-19590-30-git-send-email-pyokagan@gmail.com> (raw)
In-Reply-To: <1438696326-19590-1-git-send-email-pyokagan@gmail.com>
git-am.sh recognizes some of git-apply's options, and would pass them to
git-apply:
* --whitespace, since 8c31cb8 (git-am: --whitespace=x option.,
2006-02-28)
* -C, since 67dad68 (add -C[NUM] to git-am, 2007-02-08)
* -p, since 2092a1f (Teach git-am to pass -p option down to git-apply,
2007-02-11)
* --directory, since b47dfe9 (git-am: add --directory=<dir> option,
2009-01-11)
* --reject, since b80da42 (git-am: implement --reject option passed to
git-apply, 2009-01-23)
* --ignore-space-change, --ignore-whitespace, since 86c91f9 (git apply:
option to ignore whitespace differences, 2009-08-04)
* --exclude, since 77e9e49 (am: pass exclude down to apply, 2011-08-03)
* --include, since 58725ef (am: support --include option, 2012-03-28)
* --reject, since b80da42 (git-am: implement --reject option passed to
git-apply, 2009-01-23)
Re-implement support for these options in builtin/am.c.
Signed-off-by: Paul Tan <pyokagan@gmail.com>
---
builtin/am.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 45 insertions(+)
diff --git a/builtin/am.c b/builtin/am.c
index 727cfb8..f842f69 100644
--- a/builtin/am.c
+++ b/builtin/am.c
@@ -106,6 +106,7 @@ struct am_state {
int keep; /* enum keep_type */
int message_id;
int scissors; /* enum scissors_type */
+ struct argv_array git_apply_opts;
const char *resolvemsg;
int rebasing;
};
@@ -128,6 +129,8 @@ static void am_state_init(struct am_state *state, const char *dir)
git_config_get_bool("am.messageid", &state->message_id);
state->scissors = SCISSORS_UNSET;
+
+ argv_array_init(&state->git_apply_opts);
}
/**
@@ -140,6 +143,7 @@ static void am_state_release(struct am_state *state)
free(state->author_email);
free(state->author_date);
free(state->msg);
+ argv_array_clear(&state->git_apply_opts);
}
/**
@@ -411,6 +415,11 @@ static void am_load(struct am_state *state)
else
state->scissors = SCISSORS_UNSET;
+ read_state_file(&sb, state, "apply-opt", 1);
+ argv_array_clear(&state->git_apply_opts);
+ if (sq_dequote_to_argv_array(sb.buf, &state->git_apply_opts) < 0)
+ die(_("could not parse %s"), am_path(state, "apply-opt"));
+
state->rebasing = !!file_exists(am_path(state, "rebasing"));
strbuf_release(&sb);
@@ -585,6 +594,7 @@ static void am_setup(struct am_state *state, enum patch_format patch_format,
{
unsigned char curr_head[GIT_SHA1_RAWSZ];
const char *str;
+ struct strbuf sb = STRBUF_INIT;
if (!patch_format)
patch_format = detect_patch_format(paths);
@@ -647,6 +657,9 @@ static void am_setup(struct am_state *state, enum patch_format patch_format,
write_file(am_path(state, "scissors"), 1, "%s", str);
+ sq_quote_argv(&sb, state->git_apply_opts.argv, 0);
+ write_file(am_path(state, "apply-opt"), 1, "%s", sb.buf);
+
if (state->rebasing)
write_file(am_path(state, "rebasing"), 1, "%s", "");
else
@@ -671,6 +684,8 @@ static void am_setup(struct am_state *state, enum patch_format patch_format,
write_file(am_path(state, "next"), 1, "%d", state->cur);
write_file(am_path(state, "last"), 1, "%d", state->last);
+
+ strbuf_release(&sb);
}
/**
@@ -1058,6 +1073,8 @@ static int run_apply(const struct am_state *state, const char *index_file)
argv_array_push(&cp.args, "apply");
+ argv_array_pushv(&cp.args, state->git_apply_opts.argv);
+
if (index_file)
argv_array_push(&cp.args, "--cached");
else
@@ -1084,6 +1101,7 @@ static int build_fake_ancestor(const struct am_state *state, const char *index_f
cp.git_cmd = 1;
argv_array_push(&cp.args, "apply");
+ argv_array_pushv(&cp.args, state->git_apply_opts.argv);
argv_array_pushf(&cp.args, "--build-fake-ancestor=%s", index_file);
argv_array_push(&cp.args, am_path(state, "patch"));
@@ -1599,9 +1617,36 @@ int cmd_am(int argc, const char **argv, const char *prefix)
PARSE_OPT_NOARG | PARSE_OPT_NONEG, NULL, 0},
OPT_BOOL('c', "scissors", &state.scissors,
N_("strip everything before a scissors line")),
+ OPT_PASSTHRU_ARGV(0, "whitespace", &state.git_apply_opts, N_("action"),
+ N_("pass it through git-apply"),
+ 0),
+ OPT_PASSTHRU_ARGV(0, "ignore-space-change", &state.git_apply_opts, NULL,
+ N_("pass it through git-apply"),
+ PARSE_OPT_NOARG),
+ OPT_PASSTHRU_ARGV(0, "ignore-whitespace", &state.git_apply_opts, NULL,
+ N_("pass it through git-apply"),
+ PARSE_OPT_NOARG),
+ OPT_PASSTHRU_ARGV(0, "directory", &state.git_apply_opts, N_("root"),
+ N_("pass it through git-apply"),
+ 0),
+ OPT_PASSTHRU_ARGV(0, "exclude", &state.git_apply_opts, N_("path"),
+ N_("pass it through git-apply"),
+ 0),
+ OPT_PASSTHRU_ARGV(0, "include", &state.git_apply_opts, N_("path"),
+ N_("pass it through git-apply"),
+ 0),
+ OPT_PASSTHRU_ARGV('C', NULL, &state.git_apply_opts, N_("n"),
+ N_("pass it through git-apply"),
+ 0),
+ OPT_PASSTHRU_ARGV('p', NULL, &state.git_apply_opts, N_("num"),
+ N_("pass it through git-apply"),
+ 0),
OPT_CALLBACK(0, "patch-format", &patch_format, N_("format"),
N_("format the patch(es) are in"),
parse_opt_patchformat),
+ OPT_PASSTHRU_ARGV(0, "reject", &state.git_apply_opts, NULL,
+ N_("pass it through git-apply"),
+ PARSE_OPT_NOARG),
OPT_STRING(0, "resolvemsg", &state.resolvemsg, NULL,
N_("override error message when patch failure occurs")),
OPT_CMDMODE(0, "continue", &resume,
--
2.5.0.280.gd88bd6e
next prev parent reply other threads:[~2015-08-04 13:58 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 13:51 [PATCH v7 00/45] Make git-am a builtin Paul Tan
2015-08-04 13:51 ` [PATCH v7 01/45] wrapper: implement xopen() Paul Tan
2015-08-04 13:51 ` [PATCH v7 02/45] wrapper: implement xfopen() Paul Tan
2015-08-04 13:51 ` [PATCH v7 03/45] builtin-am: implement skeletal builtin am Paul Tan
2015-08-04 13:51 ` [PATCH v7 04/45] builtin-am: implement patch queue mechanism Paul Tan
2015-08-04 13:51 ` [PATCH v7 05/45] builtin-am: split out mbox/maildir patches with git-mailsplit Paul Tan
2015-08-04 13:51 ` [PATCH v7 06/45] builtin-am: auto-detect mbox patches Paul Tan
2015-08-04 13:51 ` [PATCH v7 07/45] builtin-am: extract patch and commit info with git-mailinfo Paul Tan
2015-08-04 13:51 ` [PATCH v7 08/45] builtin-am: apply patch with git-apply Paul Tan
2015-08-04 13:51 ` [PATCH v7 09/45] builtin-am: implement committing applied patch Paul Tan
2015-08-04 13:51 ` [PATCH v7 10/45] builtin-am: refuse to apply patches if index is dirty Paul Tan
2015-08-04 13:51 ` [PATCH v7 11/45] builtin-am: implement --resolved/--continue Paul Tan
2015-08-04 13:51 ` [PATCH v7 12/45] builtin-am: don't parse mail when resuming Paul Tan
2015-08-04 13:51 ` [PATCH v7 13/45] builtin-am: implement --skip Paul Tan
2015-08-04 13:51 ` [PATCH v7 14/45] builtin-am: implement --abort Paul Tan
2015-08-04 13:51 ` [PATCH v7 15/45] builtin-am: reject patches when there's a session in progress Paul Tan
2015-08-04 13:51 ` [PATCH v7 16/45] builtin-am: implement -q/--quiet Paul Tan
2015-08-04 13:51 ` [PATCH v7 17/45] builtin-am: exit with user friendly message on failure Paul Tan
2015-08-04 13:51 ` [PATCH v7 18/45] builtin-am: implement -s/--signoff Paul Tan
2015-08-04 13:51 ` [PATCH v7 19/45] cache-tree: introduce write_index_as_tree() Paul Tan
2015-08-04 13:51 ` [PATCH v7 20/45] builtin-am: implement --3way Paul Tan
2015-08-04 13:51 ` [PATCH v7 21/45] builtin-am: implement --rebasing mode Paul Tan
2015-08-04 13:51 ` [PATCH v7 22/45] builtin-am: bypass git-mailinfo when --rebasing Paul Tan
2015-08-04 13:51 ` [PATCH v7 23/45] builtin-am: handle stray state directory Paul Tan
2015-08-04 13:51 ` [PATCH v7 24/45] builtin-am: implement -u/--utf8 Paul Tan
2015-08-04 13:51 ` [PATCH v7 25/45] builtin-am: implement -k/--keep, --keep-non-patch Paul Tan
2015-08-04 13:51 ` [PATCH v7 26/45] builtin-am: implement --[no-]message-id, am.messageid Paul Tan
2015-08-04 13:51 ` [PATCH v7 27/45] builtin-am: support --keep-cr, am.keepcr Paul Tan
2015-08-04 13:51 ` [PATCH v7 28/45] builtin-am: implement --[no-]scissors Paul Tan
2015-08-04 13:51 ` Paul Tan [this message]
2015-08-04 13:51 ` [PATCH v7 30/45] builtin-am: implement --ignore-date Paul Tan
2015-08-04 13:51 ` [PATCH v7 31/45] builtin-am: implement --committer-date-is-author-date Paul Tan
2015-08-04 13:51 ` [PATCH v7 32/45] builtin-am: implement -S/--gpg-sign, commit.gpgsign Paul Tan
2015-08-04 13:51 ` [PATCH v7 33/45] builtin-am: invoke post-rewrite hook Paul Tan
2015-08-04 13:51 ` [PATCH v7 34/45] builtin-am: support automatic notes copying Paul Tan
2015-08-04 13:51 ` [PATCH v7 35/45] builtin-am: invoke applypatch-msg hook Paul Tan
2015-08-04 13:51 ` [PATCH v7 36/45] builtin-am: invoke pre-applypatch hook Paul Tan
2015-08-04 13:51 ` [PATCH v7 37/45] builtin-am: invoke post-applypatch hook Paul Tan
2015-08-04 13:51 ` [PATCH v7 38/45] builtin-am: rerere support Paul Tan
2015-08-04 13:52 ` [PATCH v7 39/45] builtin-am: support and auto-detect StGit patches Paul Tan
2015-08-04 13:52 ` [PATCH v7 40/45] builtin-am: support and auto-detect StGit series files Paul Tan
2015-08-04 13:52 ` [PATCH v7 41/45] builtin-am: support and auto-detect mercurial patches Paul Tan
2015-08-04 13:52 ` [PATCH v7 42/45] builtin-am: implement -i/--interactive Paul Tan
2015-08-04 13:52 ` [PATCH v7 43/45] builtin-am: implement legacy -b/--binary option Paul Tan
2015-08-04 13:52 ` [PATCH v7 44/45] builtin-am: check for valid committer ident Paul Tan
2015-08-04 13:52 ` [PATCH v7 45/45] builtin-am: remove redirection to git-am.sh Paul Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438696326-19590-30-git-send-email-pyokagan@gmail.com \
--to=pyokagan@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).