From: Dave Borowitz <dborowitz@google.com>
To: git@vger.kernel.org
Cc: Dave Borowitz <dborowitz@google.com>
Subject: [PATCH 0/7] Flags and config to sign pushes by default
Date: Thu, 13 Aug 2015 15:00:44 -0400 [thread overview]
Message-ID: <1439492451-11233-1-git-send-email-dborowitz@google.com> (raw)
Remembering to pass --signed to git push on every push is extra typing that is
easy to forget, and just leads to annoyance if the remote has a hook that makes
signed pushes required. Add a config option push.gpgSign, analogous to
commit.gpgSign, allowing users to set this flag by default.
Since --signed push will simply fail on any remote that does not advertise a
push cert nonce, actually setting this to true is not very useful (except for
the super-paranoid who would never want to push to a server that does not
support signed pushes). So, add a third state to this boolean, "if-possible",
to sign the push if and only if supported by the server. To keep parity between
the config and command line options, add a --signed-if-possible flag to git
push as well.
The "if-possible" name and weird tri-state boolean is basically a straw man,
and I am happy to change if someone has a clearer suggestion.
Dave Borowitz (7):
Documentation/git-push.txt: Document when --signed may fail
Documentation/git-send-pack.txt: Flow long synopsis line
Documentation/git-send-pack.txt: Document --signed
gitremote-helpers.txt: Document pushcert option
transport: Remove git_transport_options.push_cert
Support signing pushes iff the server supports it
Add a config option push.gpgSign for default signed pushes
Documentation/config.txt | 8 ++++++++
Documentation/git-push.txt | 11 +++++++++--
Documentation/git-send-pack.txt | 17 ++++++++++++++++-
Documentation/gitremote-helpers.txt | 3 +++
builtin/push.c | 26 +++++++++++++++++++++++++-
builtin/send-pack.c | 33 +++++++++++++++++++++++++++++++--
remote-curl.c | 14 ++++++++++----
send-pack.c | 18 +++++++++++++++---
send-pack.h | 8 +++++++-
transport-helper.c | 34 +++++++++++++++++-----------------
transport.c | 11 +++++++----
transport.h | 6 +++---
12 files changed, 151 insertions(+), 38 deletions(-)
--
2.5.0.276.gf5e568e
next reply other threads:[~2015-08-13 19:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 19:00 Dave Borowitz [this message]
2015-08-13 19:00 ` [PATCH 1/7] Documentation/git-push.txt: Document when --signed may fail Dave Borowitz
2015-08-14 23:10 ` Junio C Hamano
2015-08-17 18:11 ` Dave Borowitz
2015-08-13 19:00 ` [PATCH 2/7] Documentation/git-send-pack.txt: Flow long synopsis line Dave Borowitz
2015-08-13 19:00 ` [PATCH 3/7] Documentation/git-send-pack.txt: Document --signed Dave Borowitz
2015-08-13 19:00 ` [PATCH 4/7] gitremote-helpers.txt: Document pushcert option Dave Borowitz
2015-08-13 19:00 ` [PATCH 5/7] transport: Remove git_transport_options.push_cert Dave Borowitz
2015-08-14 23:14 ` Junio C Hamano
2015-08-13 19:00 ` [PATCH 6/7] Support signing pushes iff the server supports it Dave Borowitz
2015-08-14 23:22 ` Junio C Hamano
2015-08-19 15:18 ` Dave Borowitz
2015-08-13 19:00 ` [PATCH 7/7] Add a config option push.gpgSign for default signed pushes Dave Borowitz
2015-08-17 17:13 ` Junio C Hamano
2015-08-17 18:22 ` Dave Borowitz
2015-08-17 19:42 ` Junio C Hamano
2015-08-17 19:47 ` Junio C Hamano
2015-08-17 19:49 ` Dave Borowitz
2015-08-14 11:47 ` [PATCH 0/7] Flags and config to sign pushes by default Chris Packham
2015-08-14 18:12 ` Junio C Hamano
2015-08-14 20:29 ` Dave Borowitz
2015-08-14 20:31 ` Dave Borowitz
2015-08-14 20:45 ` Junio C Hamano
2015-08-14 20:55 ` Dave Borowitz
2015-08-14 21:03 ` Junio C Hamano
2015-08-17 17:21 ` Junio C Hamano
2015-08-17 18:32 ` Dave Borowitz
2015-08-17 18:47 ` Junio C Hamano
2015-08-17 18:54 ` Dave Borowitz
2015-08-17 19:54 ` Junio C Hamano
2015-08-17 20:00 ` Dave Borowitz
2015-08-17 20:34 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439492451-11233-1-git-send-email-dborowitz@google.com \
--to=dborowitz@google.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).