git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH 0/3] Showing merges easier with "git log"
Date: Thu, 20 Aug 2015 15:43:08 -0700	[thread overview]
Message-ID: <1440110591-12941-1-git-send-email-gitster@pobox.com> (raw)

This is a combination of two closely related topics.

 - The second patch is my long-time pet peeve (it is even on the
   leftover-bits list at git-blame blog).  When inspecting a branch,
   I often type "git log --first-parent --cc master..", and then
   realize that I need to give "-p" to actually view the condensed
   patch.  We do the same for "log -c" (combined but not desified
   form).

 - The third one is about "git log --cc master..", with which the
   user is clearly telling us that s/he wants to see interesting
   changes for both single-parent commits and for merges (otherwise
   s/he wouldn't be saying "--cc" in the first place).  Even with
   the second one that makes "--cc" imply "-p" unless another patch
   output format (e.g. "--raw") was asked, you'd need "-m", which
   was irritating.

The latter was inspired by a recent discussion, most notably

   http://thread.gmane.org/gmane.comp.version-control.git/273937/focus=273988

but implements it with a much less UI impact.  Tweaking "git log -p"
has a lot of fallout---interested parties can try it out and how two
tests in t4xxx series break.  Doing this for "log --cc" is
conceptually cleaner, as "-p" does not tell us what the user wants
to see for merges (nothing?  first-parent diff?  pairwise diff?
combined?), but "--cc" is a clear indication that dense combined
patch is desired.

Note that this conflicts with 'tr/remerge-diff' topic that has been
stalled on 'pu' for quite some time.  I'll tentatively drop that
other topic before pushing out today's integration result.  People
who are interested in that topic may want to help resurrect and
reroll it.  Hint, hint...

Junio C Hamano (3):
  log: rename "tweak" helpers
  log: when --cc is given, default to -p unless told otherwise
  log: show merge commit when --cc is given

 builtin/log.c | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

-- 
2.5.0-546-gb1bbc0d

             reply	other threads:[~2015-08-20 22:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-20 22:43 Junio C Hamano [this message]
2015-08-20 22:43 ` [PATCH 1/3] log: rename "tweak" helpers Junio C Hamano
2015-08-20 22:43 ` [PATCH 2/3] log: when --cc is given, default to -p unless told otherwise Junio C Hamano
2015-08-20 22:43 ` [PATCH 3/3] log: show merge commit when --cc is given Junio C Hamano
2015-08-21 18:03 ` [PATCH 4/3] builtin/log.c: minor reformat Junio C Hamano
2015-08-21 21:40 ` [PATCH 3z/3] log: make '-p' imply '-m --cc' Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440110591-12941-1-git-send-email-gitster@pobox.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).