From: Michael Rappazzo <rappazzo@gmail.com>
To: gitster@pobox.com, sunshine@sunshineco.com, dturner@twopensource.com
Cc: git@vger.kernel.org, Michael Rappazzo <rappazzo@gmail.com>
Subject: [PATCH v5 0/2] Worktree: for-each function and list command
Date: Sat, 22 Aug 2015 17:51:32 -0400 [thread overview]
Message-ID: <1440280294-50679-1-git-send-email-rappazzo@gmail.com> (raw)
Changes since v4:
- reduced memory usage by reusing string buffer variables
- re-scoped variables in the for-each function
- added tests for 'worktree list' with bare repos
Notes from previous discussion:
- The following snippet:
> + /* If the common_dir DOES NOT end with '/.git', then it is bare */
> + main_is_bare = !strbuf_strip_suffix(&worktree_path, "/.git");
This code is run when the current dir is in a linked worktree (not the primary
worktree). In that context, the git config _does_ report that 'core.bare' is
true when the primary repo is bare, however `is_bare_repository()` returns
false. The worktree_path also needs to the "/.git" removed from it.
Therefore, I opted to keep the code like this.
Michael Rappazzo (2):
worktree: add 'for_each_worktree' function
worktree: add 'list' command
Documentation/git-worktree.txt | 11 +++-
builtin/worktree.c | 138 +++++++++++++++++++++++++++++++++++++++++
t/t2027-worktree-list.sh | 81 ++++++++++++++++++++++++
3 files changed, 229 insertions(+), 1 deletion(-)
create mode 100755 t/t2027-worktree-list.sh
--
2.5.0
next reply other threads:[~2015-08-22 21:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-22 21:51 Michael Rappazzo [this message]
2015-08-22 21:51 ` [PATCH v5 1/2] worktree: add 'for_each_worktree' function Michael Rappazzo
2015-08-22 21:51 ` [PATCH v5 2/2] worktree: add 'list' command Michael Rappazzo
2015-08-24 18:05 ` Junio C Hamano
2015-08-25 1:07 ` Eric Sunshine
2015-08-25 3:01 ` Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440280294-50679-1-git-send-email-rappazzo@gmail.com \
--to=rappazzo@gmail.com \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).