From: Christian Couder <christian.couder@gmail.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: git <git@vger.kernel.org>, Christian Couder <chriscool@tuxfamily.org>
Subject: [PATCH v2 2/2] trailer: support multiline title
Date: Wed, 26 Aug 2015 04:51:01 +0200 [thread overview]
Message-ID: <1440557461-1078-2-git-send-email-chriscool@tuxfamily.org> (raw)
In-Reply-To: <1440557461-1078-1-git-send-email-chriscool@tuxfamily.org>
We currently ignore the first line passed to `git interpret-trailers`,
when looking for the beginning of the trailers.
Unfortunately this does not work well when a commit is created with a
line break in the title, using for example the following command:
git commit -m 'place of
code: change we made'
In this special case, it is best to look at the first line and if it
does not contain only spaces, consider that the second line is not a
trailer.
---
t/t7513-interpret-trailers.sh | 14 ++++++++++++++
trailer.c | 8 +++++++-
2 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/t/t7513-interpret-trailers.sh b/t/t7513-interpret-trailers.sh
index 9577b4e..56efe88 100755
--- a/t/t7513-interpret-trailers.sh
+++ b/t/t7513-interpret-trailers.sh
@@ -112,6 +112,20 @@ test_expect_success 'with only a title in the message' '
test_cmp expected actual
'
+test_expect_success 'with multiline title in the message' '
+ cat >expected <<-\EOF &&
+ place of
+ code: change
+
+ Reviewed-by: Peff
+ Acked-by: Johan
+ EOF
+ printf "%s\n%s\n" "place of" "code: change" |
+ git interpret-trailers --trailer "Reviewed-by: Peff" \
+ --trailer "Acked-by: Johan" >actual &&
+ test_cmp expected actual
+'
+
test_expect_success 'with config setup' '
git config trailer.ack.key "Acked-by: " &&
cat >expected <<-\EOF &&
diff --git a/trailer.c b/trailer.c
index b808868..9a54449 100644
--- a/trailer.c
+++ b/trailer.c
@@ -759,7 +759,13 @@ static int find_trailer_start(struct strbuf **lines, int count)
return count;
}
- return only_spaces ? count : 0;
+ if (only_spaces)
+ return count;
+
+ if (contains_only_spaces(lines[0]->buf))
+ return 1;
+
+ return count;
}
/* Get the index of the end of the trailers */
--
2.5.0.401.g009ef9b.dirty
next prev parent reply other threads:[~2015-08-26 2:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 2:51 [PATCH v2 1/2] trailer: ignore first line of message Christian Couder
2015-08-26 2:51 ` Christian Couder [this message]
2015-08-26 6:07 ` [PATCH v2 2/2] trailer: support multiline title Matthieu Moy
2015-08-26 6:28 ` Jacob Keller
2015-08-26 14:53 ` Christian Couder
2015-08-26 16:05 ` Junio C Hamano
2015-08-26 16:15 ` Matthieu Moy
2015-08-26 19:48 ` Junio C Hamano
2015-08-29 4:00 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440557461-1078-2-git-send-email-chriscool@tuxfamily.org \
--to=christian.couder@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).