From: Pedro Rodrigues <prodrigues1990@gmail.com>
To: git@vger.kernel.org
Subject: Bug? push --recurse-submodules=on-demandd not really recursive
Date: Sat, 05 Sep 2015 09:31:03 +0100 [thread overview]
Message-ID: <1441441863.2246.0@smtp.gmail.com> (raw)
Yesterday I was discussing this in on G+, which lead me to conclude
this is actually a bug (or, at least, a very good improvement).
When you run push --recurse-submodules=on-demand, according to the push
manpage you would expect any submodule commit missing on it's default
remote to be pushed aswell. But this only works for the submodules of
the repo you run it in, it does not work in nested submodules (hence
not being recursive at all).
I could (with my very little understanding of C) confirm this in the
source code, and the boils down to the function push_submodule on file
transport.c explicitly calling push without any params, where I would
expect it to call with --recurse-submodules=on-demand when done so on
the parent repo (and then it will actually be trully recursive).
Any thoughts?
reply other threads:[~2015-09-05 8:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441441863.2246.0@smtp.gmail.com \
--to=prodrigues1990@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).