git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Bug? push --recurse-submodules=on-demandd not really recursive
@ 2015-09-05  8:31 Pedro Rodrigues
  0 siblings, 0 replies; only message in thread
From: Pedro Rodrigues @ 2015-09-05  8:31 UTC (permalink / raw)
  To: git

Yesterday I was discussing this in on G+, which lead me to conclude 
this is actually a bug (or, at least, a very good improvement).

When you run push --recurse-submodules=on-demand, according to the push 
manpage you would expect any submodule commit missing on it's default 
remote to be pushed aswell. But this only works for the submodules of 
the repo you run it in, it does not work in nested submodules (hence 
not being recursive at all).

I could (with my very little understanding of C) confirm this in the 
source code, and the boils down to the function push_submodule on file 
transport.c explicitly calling push without any params, where I would 
expect it to call with --recurse-submodules=on-demand when done so on 
the parent repo (and then it will actually be trully recursive).

Any thoughts?

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-09-05  8:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-05  8:31 Bug? push --recurse-submodules=on-demandd not really recursive Pedro Rodrigues

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).