From: larsxschneider@gmail.com
To: git@vger.kernel.org
Cc: gitster@pobox.com, luke@diamand.org,
Lars Schneider <larsxschneider@gmail.com>
Subject: [PATCH v2] git-p4: improve path encoding verbose output
Date: Wed, 16 Sep 2015 14:37:04 +0200 [thread overview]
Message-ID: <1442407024-33516-2-git-send-email-larsxschneider@gmail.com> (raw)
In-Reply-To: <1442407024-33516-1-git-send-email-larsxschneider@gmail.com>
From: Lars Schneider <larsxschneider@gmail.com>
If a path with non-ASCII characters is detected then print the
encoding and the encoded string in verbose mode.
Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
---
git-p4.py | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/git-p4.py b/git-p4.py
index d45cf2b..e7510a9 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -2220,16 +2220,15 @@ class P4Sync(Command, P4UserMap):
text = regexp.sub(r'$\1$', text)
contents = [ text ]
- if gitConfig("git-p4.pathEncoding"):
- relPath = relPath.decode(gitConfig("git-p4.pathEncoding")).encode('utf8', 'replace')
- elif self.verbose:
- try:
- relPath.decode('ascii')
- except:
- print (
- "Path with Non-ASCII characters detected and no path encoding defined. "
- "Please check the encoding: %s" % relPath
- )
+ try:
+ relPath.decode('ascii')
+ except:
+ encoding = 'utf8'
+ if gitConfig('git-p4.pathEncoding'):
+ encoding = gitConfig('git-p4.pathEncoding')
+ relPath = relPath.decode(encoding).encode('utf8', 'replace')
+ if self.verbose:
+ print 'Path with non-ASCII characters detected. Used %s to encode: %s ' % (encoding, relPath)
self.gitStream.write("M %s inline %s\n" % (git_mode, relPath))
--
2.5.1
prev parent reply other threads:[~2015-09-16 12:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 12:37 [PATCH v2] git-p4: improve path encoding verbose output larsxschneider
2015-09-16 12:37 ` larsxschneider [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442407024-33516-2-git-send-email-larsxschneider@gmail.com \
--to=larsxschneider@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=luke@diamand.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).