* [PATCH] git-gui: remove the garbage collection hint
@ 2015-09-29 17:33 Beat Bolli
0 siblings, 0 replies; only message in thread
From: Beat Bolli @ 2015-09-29 17:33 UTC (permalink / raw)
To: git; +Cc: Beat Bolli, Pat Thoyts
Git core has had automatic garbage collection for a long time.
Git-gui does not need a similar heuristic.
Signed-off-by: Beat Bolli <dev+git@drbeat.li>
Cc: Pat Thoyts <patthoyts@users.sourceforge.net>
---
git-gui.sh | 3 ---
lib/database.tcl | 26 --------------------------
2 files changed, 29 deletions(-)
diff --git a/git-gui.sh b/git-gui.sh
index 11048c7..2866777 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -4004,9 +4004,6 @@ after 1 {
$ui_comm configure -state disabled -background gray
}
}
-if {[is_enabled multicommit] && ![is_config_false gui.gcwarning]} {
- after 1000 hint_gc
-}
if {[is_enabled retcode]} {
bind . <Destroy> {+terminate_me %W}
}
diff --git a/lib/database.tcl b/lib/database.tcl
index 1f187ed..808bdf6 100644
--- a/lib/database.tcl
+++ b/lib/database.tcl
@@ -87,29 +87,3 @@ proc do_fsck_objects {} {
lappend cmd --strict
console::exec $w $cmd
}
-
-proc hint_gc {} {
- set ndirs 1
- set limit 8
- if {[is_Windows]} {
- set ndirs 4
- set limit 1
- }
-
- set count [llength [glob \
- -nocomplain \
- -- \
- [gitdir objects 4\[0-[expr {$ndirs-1}]\]/*]]]
-
- if {$count >= $limit * $ndirs} {
- set objects_current [expr {$count * 256/$ndirs}]
- if {[ask_popup \
- [mc "This repository currently has approximately %i loose objects.
-
-To maintain optimal performance it is strongly recommended that you compress the database.
-
-Compress the database now?" $objects_current]] eq yes} {
- do_gc
- }
- }
-}
--
2.5.0.492.g918e48c
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-09-29 17:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-29 17:33 [PATCH] git-gui: remove the garbage collection hint Beat Bolli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).