git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Karthik Nayak <karthik.188@gmail.com>
To: git@vger.kernel.org
Cc: christian.couder@gmail.com, Matthieu.Moy@grenoble-inp.fr,
	gitster@pobox.com, Karthik Nayak <Karthik.188@gmail.com>
Subject: [PATCH 0/9] port branch.c to use ref-filter printing APIs
Date: Fri,  2 Oct 2015 23:08:57 +0530	[thread overview]
Message-ID: <1443807546-5985-1-git-send-email-Karthik.188@gmail.com> (raw)

This series ports over branch.c to use ref-filter APIs
This is the last part of unification of 'git branch -l', 'git tag -l'
and 'git for-each-ref'.

There are a few topics worth discussing here :

1. [7/9] This ensures that when we use the "%(upstream:track)" atom we
print "[gone]" for upstreams which are invalid. We either implement
this and try to mimic what branch.c does when we use the verbose
option or we can drop this in branch.c.

2. [8/9] The usage of get_format() function in branch.c which provides
us the needed format for printing. This seems overly complex to the
uninitiated as it uses a complex atom combinations to mimic the
existing branch printing format.

Karthik Nayak (9):
  ref-filter: implement %(if), %(then), and %(else) atoms
  ref-filter: implement %(if:equals=<string>) and
    %(if:notequals=<string>)
  ref-filter: add support for %(path) atom
  ref-filter: modify "%(objectname:short)" to take length
  ref-filter: adopt get_head_description() from branch.c
  ref-filter: introduce format_ref_array_item()
  ref-filter: make %(upstream:track) prints "[gone]" for invalid
    upstreams
  branch: use ref-filter printing APIs
  branch: implement '--format' option

 Documentation/git-branch.txt       |   7 +-
 Documentation/git-for-each-ref.txt |  32 ++++-
 builtin/branch.c                   | 262 ++++++++++---------------------------
 ref-filter.c                       | 250 +++++++++++++++++++++++++++++++----
 ref-filter.h                       |   3 +
 t/t3203-branch-output.sh           |  11 ++
 t/t6040-tracking-info.sh           |  12 +-
 t/t6300-for-each-ref.sh            |  24 +++-
 t/t6302-for-each-ref-filter.sh     | 105 +++++++++++++++
 9 files changed, 480 insertions(+), 226 deletions(-)

-- 
2.6.0

             reply	other threads:[~2015-10-02 17:39 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-02 17:38 Karthik Nayak [this message]
2015-10-02 17:38 ` [PATCH 1/9] ref-filter: implement %(if), %(then), and %(else) atoms Karthik Nayak
2015-10-02 20:45   ` Junio C Hamano
2015-10-03  7:05     ` Karthik Nayak
2015-10-03  9:39   ` Matthieu Moy
2015-10-03 17:01     ` Junio C Hamano
2015-10-04  8:02       ` Matthieu Moy
2015-10-04 17:21         ` Junio C Hamano
2015-10-04 13:59     ` Karthik Nayak
2015-10-02 17:38 ` [PATCH 2/9] ref-filter: implement %(if:equals=<string>) and %(if:notequals=<string>) Karthik Nayak
2015-10-02 20:54   ` Junio C Hamano
2015-10-03  7:14     ` Karthik Nayak
2015-10-02 17:39 ` [PATCH 3/9] ref-filter: add support for %(path) atom Karthik Nayak
2015-10-03 10:02   ` Matthieu Moy
2015-10-04 17:07     ` Karthik Nayak
2015-10-04 17:51       ` Matthieu Moy
2015-10-04 18:44         ` Junio C Hamano
2015-10-05  6:40           ` Matthieu Moy
2015-10-04 19:12         ` Karthik Nayak
2015-10-02 17:39 ` [PATCH 4/9] ref-filter: modify "%(objectname:short)" to take length Karthik Nayak
2015-10-02 21:02   ` Junio C Hamano
2015-10-03  7:28     ` Karthik Nayak
2015-10-02 17:39 ` [PATCH 5/9] ref-filter: adopt get_head_description() from branch.c Karthik Nayak
2015-10-02 17:39 ` [PATCH 6/9] ref-filter: introduce format_ref_array_item() Karthik Nayak
2015-10-03 12:02   ` Matthieu Moy
2015-10-05  7:49     ` Karthik Nayak
2015-10-05  8:49       ` Matthieu Moy
2015-10-06 19:16         ` Karthik Nayak
2015-10-06 19:38           ` Matthieu Moy
2015-10-06 19:50             ` Karthik Nayak
2015-10-02 17:39 ` [PATCH 7/9] ref-filter: make %(upstream:track) prints "[gone]" for invalid upstreams Karthik Nayak
2015-10-03 12:08   ` Matthieu Moy
2015-10-05  7:49     ` Karthik Nayak
2015-10-02 17:39 ` [PATCH 8/9] branch: use ref-filter printing APIs Karthik Nayak
2015-10-03 12:41   ` Matthieu Moy
2015-10-05 17:46     ` Karthik Nayak
2015-10-05 18:43       ` Matthieu Moy
2015-10-06 15:30         ` Karthik Nayak
2015-10-06 19:03           ` Matthieu Moy
2015-10-07 16:47             ` Karthik Nayak
2015-10-07 17:58               ` Matthieu Moy
2015-10-07 18:02                 ` Karthik Nayak
2015-10-02 17:39 ` [PATCH 9/9] branch: implement '--format' option Karthik Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443807546-5985-1-git-send-email-Karthik.188@gmail.com \
    --to=karthik.188@gmail.com \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).