From: Karthik Nayak <karthik.188@gmail.com>
To: git@vger.kernel.org
Cc: christian.couder@gmail.com, Matthieu.Moy@grenoble-inp.fr,
gitster@pobox.com, Karthik Nayak <Karthik.188@gmail.com>
Subject: [PATCH 3/9] ref-filter: add support for %(path) atom
Date: Fri, 2 Oct 2015 23:09:00 +0530 [thread overview]
Message-ID: <1443807546-5985-4-git-send-email-Karthik.188@gmail.com> (raw)
In-Reply-To: <1443807546-5985-1-git-send-email-Karthik.188@gmail.com>
This adds %(path) and %(path:short) atoms. The %(path) atom will print
the path of the given ref, while %(path:short) will only print the
subdirectory of the given ref.
Add tests and documentation for the same.
---
Documentation/git-for-each-ref.txt | 5 +++++
ref-filter.c | 17 +++++++++++++++++
t/t6302-for-each-ref-filter.sh | 39 ++++++++++++++++++++++++++++++++++++++
3 files changed, 61 insertions(+)
diff --git a/Documentation/git-for-each-ref.txt b/Documentation/git-for-each-ref.txt
index 5c12c2f..6a476ba 100644
--- a/Documentation/git-for-each-ref.txt
+++ b/Documentation/git-for-each-ref.txt
@@ -145,6 +145,11 @@ if::
compare the value between the %(if:...) and %(then) atoms with the
given string.
+path::
+ The path of the given ref. For a shortened version listing
+ only the name of the directory the ref is under append
+ `:short`.
+
In addition to the above, for commit and tag objects, the header
field names (`tree`, `parent`, `object`, `type`, and `tag`) can
be used to specify the value in the header field.
diff --git a/ref-filter.c b/ref-filter.c
index da7723b..b0e86ae 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -58,6 +58,7 @@ static struct {
{ "if" },
{ "then" },
{ "else" },
+ { "path" },
};
#define REF_FORMATTING_STATE_INIT { 0, NULL }
@@ -1042,6 +1043,22 @@ static void populate_value(struct ref_array_item *ref)
} else if (!strcmp(name, "else")) {
v->handler = else_atom_handler;
continue;
+ } else if (match_atom_name(name, "path", &valp)) {
+ const char *sp, *ep;
+
+ if (ref->kind & FILTER_REFS_DETACHED_HEAD)
+ continue;
+
+ sp = strchr(ref->refname, '/');
+ ep = strchr(++sp, '/');
+
+ if (!valp)
+ sp = ref->refname;
+ else if (strcmp(valp, "short"))
+ die(_("format: invalid value given path:%s"), valp);
+
+ v->s = xstrndup(sp, ep - sp);
+ continue;
} else
continue;
diff --git a/t/t6302-for-each-ref-filter.sh b/t/t6302-for-each-ref-filter.sh
index d7f7a18..5557657 100755
--- a/t/t6302-for-each-ref-filter.sh
+++ b/t/t6302-for-each-ref-filter.sh
@@ -312,6 +312,7 @@ test_expect_success 'check %(if:equals=<string>)' '
test_cmp expect actual
'
+
test_expect_success 'check %(if:notequals=<string>)' '
git for-each-ref --format="%(if:notequals=master)%(refname:short)%(then)Not master%(else)Found master%(end)" refs/heads/ >actual &&
cat >expect <<-\EOF &&
@@ -321,4 +322,42 @@ test_expect_success 'check %(if:notequals=<string>)' '
test_cmp expect actual
'
+test_expect_success 'check %(path)' '
+ git for-each-ref --format="%(path)" >actual &&
+ cat >expect <<-\EOF &&
+ refs/heads
+ refs/heads
+ refs/odd
+ refs/tags
+ refs/tags
+ refs/tags
+ refs/tags
+ refs/tags
+ refs/tags
+ refs/tags
+ refs/tags
+ refs/tags
+ EOF
+ test_cmp expect actual
+'
+
+test_expect_success 'check %(path:short)' '
+ git for-each-ref --format="%(path:short)" >actual &&
+ cat >expect <<-\EOF &&
+ heads
+ heads
+ odd
+ tags
+ tags
+ tags
+ tags
+ tags
+ tags
+ tags
+ tags
+ tags
+ EOF
+ test_cmp expect actual
+'
+
test_done
--
2.6.0
next prev parent reply other threads:[~2015-10-02 17:39 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 17:38 [PATCH 0/9] port branch.c to use ref-filter printing APIs Karthik Nayak
2015-10-02 17:38 ` [PATCH 1/9] ref-filter: implement %(if), %(then), and %(else) atoms Karthik Nayak
2015-10-02 20:45 ` Junio C Hamano
2015-10-03 7:05 ` Karthik Nayak
2015-10-03 9:39 ` Matthieu Moy
2015-10-03 17:01 ` Junio C Hamano
2015-10-04 8:02 ` Matthieu Moy
2015-10-04 17:21 ` Junio C Hamano
2015-10-04 13:59 ` Karthik Nayak
2015-10-02 17:38 ` [PATCH 2/9] ref-filter: implement %(if:equals=<string>) and %(if:notequals=<string>) Karthik Nayak
2015-10-02 20:54 ` Junio C Hamano
2015-10-03 7:14 ` Karthik Nayak
2015-10-02 17:39 ` Karthik Nayak [this message]
2015-10-03 10:02 ` [PATCH 3/9] ref-filter: add support for %(path) atom Matthieu Moy
2015-10-04 17:07 ` Karthik Nayak
2015-10-04 17:51 ` Matthieu Moy
2015-10-04 18:44 ` Junio C Hamano
2015-10-05 6:40 ` Matthieu Moy
2015-10-04 19:12 ` Karthik Nayak
2015-10-02 17:39 ` [PATCH 4/9] ref-filter: modify "%(objectname:short)" to take length Karthik Nayak
2015-10-02 21:02 ` Junio C Hamano
2015-10-03 7:28 ` Karthik Nayak
2015-10-02 17:39 ` [PATCH 5/9] ref-filter: adopt get_head_description() from branch.c Karthik Nayak
2015-10-02 17:39 ` [PATCH 6/9] ref-filter: introduce format_ref_array_item() Karthik Nayak
2015-10-03 12:02 ` Matthieu Moy
2015-10-05 7:49 ` Karthik Nayak
2015-10-05 8:49 ` Matthieu Moy
2015-10-06 19:16 ` Karthik Nayak
2015-10-06 19:38 ` Matthieu Moy
2015-10-06 19:50 ` Karthik Nayak
2015-10-02 17:39 ` [PATCH 7/9] ref-filter: make %(upstream:track) prints "[gone]" for invalid upstreams Karthik Nayak
2015-10-03 12:08 ` Matthieu Moy
2015-10-05 7:49 ` Karthik Nayak
2015-10-02 17:39 ` [PATCH 8/9] branch: use ref-filter printing APIs Karthik Nayak
2015-10-03 12:41 ` Matthieu Moy
2015-10-05 17:46 ` Karthik Nayak
2015-10-05 18:43 ` Matthieu Moy
2015-10-06 15:30 ` Karthik Nayak
2015-10-06 19:03 ` Matthieu Moy
2015-10-07 16:47 ` Karthik Nayak
2015-10-07 17:58 ` Matthieu Moy
2015-10-07 18:02 ` Karthik Nayak
2015-10-02 17:39 ` [PATCH 9/9] branch: implement '--format' option Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443807546-5985-4-git-send-email-Karthik.188@gmail.com \
--to=karthik.188@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).