git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: atousa.p@gmail.com
To: git@vger.kernel.org
Cc: Atousa Pahlevan Duprat <apahlevan@ieee.org>
Subject: [PATCH v4 1/3] Provide another level of abstraction for the SHA1 utilities.
Date: Wed,  4 Nov 2015 22:38:41 -0800	[thread overview]
Message-ID: <1446705523-30701-1-git-send-email-apahlevan@ieee.org> (raw)
In-Reply-To: <CAPig+cS7NktyhveQUiBFkRtJH1D-Aif861e9qshL2R=ZNg2+Lw@mail.gmail.com>

From: Atousa Pahlevan Duprat <apahlevan@ieee.org>

The git source uses git_SHA1_Update() and friends to call
into the code that computes the hashes.  This is can then be
mapped directly to an implementation that computes the hash,
such as platform_SHA1_Update(); or as we will do in a subsequent
patch, it can be mapped to something more complex that will in turn call
into the platform's SHA implementation.

Signed-off-by: Atousa Pahlevan Duprat <apahlevan@ieee.org>
---
 cache.h | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)

diff --git a/cache.h b/cache.h
index a9aaa03..a934a2e 100644
--- a/cache.h
+++ b/cache.h
@@ -12,10 +12,21 @@
 
 #include SHA1_HEADER
 #ifndef git_SHA_CTX
-#define git_SHA_CTX	SHA_CTX
-#define git_SHA1_Init	SHA1_Init
-#define git_SHA1_Update	SHA1_Update
-#define git_SHA1_Final	SHA1_Final
+
+/* platform's underlying implementation of SHA1, could be OpenSSL,
+   blk_SHA, Apple CommonCrypto, etc...  */
+#define platform_SHA_CTX	SHA_CTX
+#define platform_SHA1_Init	SHA1_Init
+#define platform_SHA1_Update	SHA1_Update
+#define platform_SHA1_Final    	SHA1_Final
+
+/* git may call platform's underlying implementation of SHA1 directly,
+   or may call it through a wrapper */
+#define git_SHA_CTX		platform_SHA_CTX
+#define git_SHA1_Init		platform_SHA1_Init
+#define git_SHA1_Update		platform_SHA1_Update
+#define git_SHA1_Final		platform_SHA1_Final
+
 #endif
 
 #include <zlib.h>
-- 
2.4.9 (Apple Git-60)

  reply	other threads:[~2015-11-05  7:09 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28 23:10 git fsck failure on OS X with files >= 4 GiB Rafael Espíndola
2015-10-29  6:46 ` Filipe Cabecinhas
     [not found] ` <CAEDE8505fXAwVXx=EZwxPHvXpMByzpnXJ9LBgfx3U6VUaFbPHw@mail.gmail.com>
2015-10-29 10:46   ` Rafael Espíndola
2015-10-29 15:15     ` Filipe Cabecinhas
2015-10-29 16:02       ` Atousa Duprat
2015-10-29 17:19         ` Junio C Hamano
2015-10-30  2:15           ` Atousa Duprat
2015-10-30 22:12             ` [PATCH] Limit the size of the data block passed to SHA1_Update() Atousa Pahlevan Duprat
2015-10-30 22:22               ` Junio C Hamano
2015-11-01  6:41                 ` Atousa Duprat
2015-11-01 18:31                   ` Junio C Hamano
2015-11-01  1:32               ` Eric Sunshine
2015-11-01  6:32                 ` atousa.p
2015-11-01  8:30                   ` Eric Sunshine
2015-11-01 18:37                   ` Junio C Hamano
2015-11-02 20:52                     ` Atousa Duprat
2015-11-02 21:21                       ` Junio C Hamano
2015-11-03  6:58                         ` [PATCH 1/2] " atousa.p
2015-11-03 11:51                           ` Torsten Bögershausen
2015-11-04  4:24                             ` [PATCH] " atousa.p
2015-11-04 19:51                               ` Eric Sunshine
2015-11-05  6:38                                 ` atousa.p [this message]
2015-11-05 18:29                                   ` [PATCH v4 1/3] Provide another level of abstraction for the SHA1 utilities Junio C Hamano
2015-11-05  6:38                                 ` [PATCH v4 2/3] Limit the size of the data block passed to SHA1_Update() atousa.p
2015-11-05 18:29                                   ` Junio C Hamano
2015-11-11 23:46                                     ` Atousa Duprat
2015-11-05  6:38                                 ` [PATCH v4 3/3] Move all the SHA1 implementations into one directory atousa.p
2015-11-05 18:29                                   ` Junio C Hamano
2015-11-04  4:27                             ` [PATCH 1/2] Limit the size of the data block passed to SHA1_Update() Atousa Duprat
2015-11-04 17:09                         ` [PATCH] " Junio C Hamano
2015-10-30 22:18             ` Atousa Pahlevan Duprat
2015-10-30 22:26               ` Randall S. Becker
2015-10-31 17:35                 ` Junio C Hamano
2015-11-01  6:37                 ` Atousa Duprat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446705523-30701-1-git-send-email-apahlevan@ieee.org \
    --to=atousa.p@gmail.com \
    --cc=apahlevan@ieee.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).