From: David Turner <dturner@twopensource.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: Duy Nguyen <pclouds@gmail.com>,
Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>,
Git <git@vger.kernel.org>
Subject: Re: [PATCH 0/5] Use watchman to reduce index refresh time
Date: Tue, 10 Nov 2015 16:04:28 -0500 [thread overview]
Message-ID: <1447189468.20147.32.camel@twopensource.com> (raw)
In-Reply-To: <CAP8UFD0rAL62eFdtLo__ta=_Yhq4cdRcqmfYTqw3imNa5Lde-A@mail.gmail.com>
On Mon, 2015-11-09 at 21:06 +0100, Christian Couder wrote:
> Using David's series I get worse results than all of the above but I
> guess it's because his series is based on an ancient git version
> (v2.0.0-rc0).
My more-recent series is on top of 2.4, but (for webkit):
mine: 0m0.206s
duy's: 0m0.107s
However, I'm getting occasional index-helper segfaults due to
istate->last_update being NULL. (I'm using Duy's index-helper branch
from his github + this patchset + a function signature fix due to a
newer version of libwatchman). I haven't looked into why this is --
maybe accidentally mixing git versions while testing?
Also, after messing around for a while (on Duy's branch), I ended up in
a state where git status would take ~2.5s every time. The index helper
was alive but evidently not working right. Killing and restarting it
worked. Actually, I think I can repro this more easily: "git rm
Changelog" seems to put the index-helper into this state.
next prev parent reply other threads:[~2015-11-10 21:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-01 13:55 [PATCH 0/5] Use watchman to reduce index refresh time Nguyễn Thái Ngọc Duy
2015-11-01 13:55 ` [PATCH 1/5] read-cache: add watchman 'WAMA' extension Nguyễn Thái Ngọc Duy
2015-11-02 22:03 ` David Turner
2015-11-03 19:17 ` Duy Nguyen
2015-11-03 19:49 ` David Turner
2015-11-01 13:55 ` [PATCH 2/5] Add watchman support to reduce index refresh cost Nguyễn Thái Ngọc Duy
2015-11-02 21:19 ` David Turner
2015-11-01 13:55 ` [PATCH 3/5] read-cache: allow index-helper to prepare shm before git reads it Nguyễn Thái Ngọc Duy
2015-11-01 13:55 ` [PATCH 4/5] index-helper: use watchman to avoid refreshing index with lstat() Nguyễn Thái Ngọc Duy
2015-11-01 13:55 ` [PATCH 5/5] update-index: enable/disable watchman support Nguyễn Thái Ngọc Duy
2015-11-02 14:54 ` [PATCH 0/5] Use watchman to reduce index refresh time Paolo Ciarrocchi
2015-11-02 19:23 ` Duy Nguyen
2015-11-03 9:21 ` Duy Nguyen
2015-11-03 10:26 ` Paolo Ciarrocchi
2015-11-09 20:06 ` Christian Couder
2015-11-10 21:04 ` David Turner [this message]
2015-11-20 9:45 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447189468.20147.32.camel@twopensource.com \
--to=dturner@twopensource.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=paolo.ciarrocchi@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).