From: Michael Rappazzo <rappazzo@gmail.com>
To: gitster@pobox.com
Cc: git@vger.kernel.org, mhagger@alum.mit.edu, peff@peff.net,
dturner@twopensource.com, pclouds@gmail.com,
sunshine@sunshineco.com, Michael Rappazzo <rappazzo@gmail.com>
Subject: [PATCH 3/5] ff-refs: add --dry-run and --skip-worktree options
Date: Tue, 10 Nov 2015 21:11:23 -0500 [thread overview]
Message-ID: <1447207885-10911-4-git-send-email-rappazzo@gmail.com> (raw)
In-Reply-To: <1447207885-10911-1-git-send-email-rappazzo@gmail.com>
'--dry-run' reports the updatable state of each ref without acutally
updating any refs. Refs which are fast-forwardable are reported as
'WOULD-UPDATE'.
'--skip-worktrees' does not update refs which are checked out in any
worktree. Branches which are fast-forwardable but checked out in a
worktree are reported as 'SKIPPED'. With `--dry-run` these are reported
'WOULD-SKIP'.
Signed-off-by: Michael Rappazzo <rappazzo@gmail.com>
---
builtin/ff-refs.c | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/builtin/ff-refs.c b/builtin/ff-refs.c
index f14afc5..ae68cfb 100644
--- a/builtin/ff-refs.c
+++ b/builtin/ff-refs.c
@@ -5,6 +5,8 @@
#include "run-command.h"
#include "worktree.h"
+int dry_run = 0;
+int no_wt = 0;
struct worktree **worktrees;
const char *padding = ".....................................................";
@@ -18,6 +20,7 @@ enum ff_result_type {
UPDATABLE,
REMOTE_MISSING,
NON_FAST_FORWARD,
+ SKIPPED,
UNABLE_TO_UPDATE
};
@@ -48,11 +51,13 @@ static const char *result_type_str(enum ff_result_type result_type)
case UP_TO_DATE:
return _("UP-TO-DATE");
case UPDATABLE:
- return _("WOULD-UPDATE");
+ return dry_run ? _("WOULD-UPDATE") : _("UPDATED");
case REMOTE_MISSING:
return _("REMOTE-MISSING");
case NON_FAST_FORWARD:
return _("NON-FAST-FORWARD");
+ case SKIPPED:
+ return dry_run ? _("WOULD-SKIP") : _("SKIPPED");
default:
return _("UNABLE-TO-UPDATE");
}
@@ -135,7 +140,7 @@ static void process_refs(struct ff_ref_data *data)
printf(" %s -> %s%*.*s",
details->branch->name, details->shortened_upstream, padLen, padLen, padding);
- if (details->result_type == UPDATABLE)
+ if (!dry_run && details->result_type == UPDATABLE)
do_ref_update(data, details);
printf("[%s]\n", result_type_str(details->result_type));
@@ -208,6 +213,9 @@ static int analize_refs(const char *refname,
else if (!in_merge_bases(details->branch_commit, details->upstream_commit))
details->result_type = NON_FAST_FORWARD;
+ else if (no_wt && details->wt)
+ details->result_type = SKIPPED;
+
else
details->result_type = UPDATABLE;
}
@@ -233,6 +241,9 @@ int cmd_ff_refs(int argc, const char **argv, const char *prefix)
int ret = 0;
struct option options[] = {
+ OPT_BOOL(0, "dry-run", &dry_run, N_("show what would be fast-forwarded")),
+ OPT_BOOL(0, "skip-worktrees", &no_wt,
+ N_("skip refs checked out in any worktree")),
OPT_END()
};
--
2.6.2
next prev parent reply other threads:[~2015-11-11 2:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 2:11 [PATCH 0/5] ff-refs: builtin command to fast-forward local refs Michael Rappazzo
2015-11-11 2:11 ` [PATCH 1/5] ff-refs: builtin cmd to check and fast forward local refs to their upstream Michael Rappazzo
2015-11-11 2:11 ` [PATCH 2/5] ff-refs: update each updatable ref Michael Rappazzo
2015-11-11 2:11 ` Michael Rappazzo [this message]
2015-11-11 2:11 ` [PATCH 4/5] ff-refs: Add documentation Michael Rappazzo
2015-11-11 2:11 ` [PATCH 5/5] ff-refs: Add tests Michael Rappazzo
2015-11-11 10:41 ` [PATCH 0/5] ff-refs: builtin command to fast-forward local refs Michael J Gruber
2015-11-11 12:32 ` Mike Rappazzo
[not found] ` <CANoM8SWxMeDjwy-GwVc+En8D7N8LyzzsBKtX_MbiS4Z49DjD7g@mail.gmail.com>
2015-11-17 15:28 ` Michael J Gruber
2015-11-17 15:36 ` Mike Rappazzo
2015-11-18 9:56 ` Johannes Schindelin
2015-11-24 22:39 ` Jeff King
2015-12-01 0:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447207885-10911-4-git-send-email-rappazzo@gmail.com \
--to=rappazzo@gmail.com \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).